Update supported go versions to 1.22+1.23 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
commented
Aug 15, 2024
| @@ -50,7 +50,6 @@ var expectedMetrics = []string{ | |||
| "go_godebug_non_default_behavior_http2client_events_total", | |||
| "go_godebug_non_default_behavior_http2server_events_total", | |||
| "go_godebug_non_default_behavior_installgoroot_events_total", | |||
| "go_godebug_non_default_behavior_jstmpllitinterp_events_total", | |||
There was a problem hiding this comment.
this seems to be no longer in go 1.23.
16fe0ae to
2bed71d
Compare
konradreiche
approved these changes
Aug 15, 2024
kylelemons
approved these changes
Aug 15, 2024
| @@ -19,7 +19,7 @@ type CallContainer struct { | |||
| func (c *CallContainer) AddCall(call string, fail bool) error { | |||
| c.Calls = append(c.Calls, call) | |||
| if fail { | |||
| return fmt.Errorf(call) | |||
| return errors.New(call) | |||
There was a problem hiding this comment.
does go vet call this out now?
There was a problem hiding this comment.
staticcheck calls this out now: https://github.com/reddit/baseplate.go/actions/runs/10407002603/job/28821319767#step:6:7
There was a problem hiding this comment.
the main point I think is the dynamic string part, so a string literal would still work, and if you use something like fmt.Errorf("%s", call) that likely also works.
There was a problem hiding this comment.
which I think makes sense, as there's a possibility call contains some format verbs and then fmt.Errorf(call) would cause an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.