Skip to content

Commit

Permalink
Update supported go versions to 1.22+1.23
Browse files Browse the repository at this point in the history
  • Loading branch information
fishy committed Aug 15, 2024
1 parent 63f8545 commit 2bed71d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/go-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
strategy:
matrix:
go-version:
- "1.21"
- "1.22"
- "1.23"

container:
image: golang:${{ matrix.go-version }}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/reddit/baseplate.go

go 1.21
go 1.22

require (
github.com/Shopify/sarama v1.29.1
Expand Down
1 change: 0 additions & 1 deletion internal/admin/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ var expectedMetrics = []string{
"go_godebug_non_default_behavior_http2client_events_total",
"go_godebug_non_default_behavior_http2server_events_total",
"go_godebug_non_default_behavior_installgoroot_events_total",
"go_godebug_non_default_behavior_jstmpllitinterp_events_total",
"go_godebug_non_default_behavior_multipartmaxheaders_events_total",
"go_godebug_non_default_behavior_multipartmaxparts_events_total",
"go_godebug_non_default_behavior_multipathtcp_events_total",
Expand Down
4 changes: 2 additions & 2 deletions tracing/hooks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package tracing_test

import (
"context"
"fmt"
"errors"
"reflect"
"testing"

Expand All @@ -19,7 +19,7 @@ type CallContainer struct {
func (c *CallContainer) AddCall(call string, fail bool) error {
c.Calls = append(c.Calls, call)
if fail {
return fmt.Errorf(call)
return errors.New(call)
}
return nil
}
Expand Down

0 comments on commit 2bed71d

Please sign in to comment.