[sync]: odh to rhoai for 2.11 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
Skipping CI for Draft Pull Request. |
* Add support for default ingress cert
* Refactor watches
* Add Watch for Ingress cert secret
* Update manifests
* Fix linters and api docs
* Update scheme and roles
* Address comments
* Update tests to match default values
* chore: refactors cert creation
it does not have to be part of Feature struct/methods
Signed-off-by: bartoszmajsak <bartosz.majsak@gmail.com>
* Change default value to OpenshiftDefaultIngress
* Update default secret
* Add e2e tests
* Update tests for Managed Serving
* Update serverless tests
* Sync manifests
|
/lgtm |
|
@zdtsw: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…hat-data-services#885) - change trustCABundle to pointer, so if not set it is Removed - keep serviceMesh only add a check so if not set it is Removed - abstruct into a function skip create CM for trustcabundle - fix(e2e): check on wrong component - fix(test): set servicemesh to unmanaged since we are using pointer now - fix lint in test which we always have error for kserve which is expected we do need continue with "Removed" to cleanup manifests from ksever - do not set check on servicemesh, only component status needed - update configureServiceMesh... forgot to check in code - fix return type of RemoveCABundleConfigMapInAllNamespaces - fix: update test case since we have enabled servicemesh operator in e2e --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
|
no rush for this PR @etirelli , thought it is code freeze tomorrow, but we can wait it for next week 😄 |
…ervices#1067) PR red-hat-data-services#1022 promoted knative default secret name as the default for entire platform. This can be confusing, therefore this change makes it local to kserve again.
Removes linters which are not maintained anymore and deprecated. Most has been replaced with `unused` linter which is enabled by default.
…ed-hat-data-services#996) - both depedent operators have been check in configureServerlessFeatures Signed-off-by: Wen Zhou <wenzhou@redhat.com>
…ervices#1071) status.go is intended for general purpose funcs, not domain specific.
Fixes - removed irrelavant //nolint comments (see config updates below) - converted unused func params to blank identifier when impl does not need it New linters perfsprint - disabled fmt.Sprintf checks for one element - adjusted errors creation to use errors.New instead of fmt.Errorf when no-arg strings are used as messages Configuration updates - configured revive to not complain about dot-imports for testing libraries - adjusted configuration yaml due to changes in the structure (skip-dirs) - some deprecated linters were removed from golangci-lint toolchain so they are now gone from the config too
…t-data-services#1078) This linter makes sure that we use consitent aliases for imports, which are especially handy when it comes to versioned api packages. With simple rules we can ensure that e.g. "k8s.io/api/core/v1" is consistently aliased as corev1. In case of "k8s.io/apimachinery/pkg/api/errors" it will expect k8serr alias instead of apierrs, as former is more descriptive.
…-data-services#1077) - update selfsigned cert if previous one has a different type - create new one with kubernetes.io/tls as type Signed-off-by: Wen Zhou <wenzhou@redhat.com>
…s#1080) * chore: remove duplicated logic by function call - change if-else-if to switch - fast return in recreateSecret case --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com>
…-data-services#1056) * This PR creates kserver-local-gateway Gateway and Service object. Jira: https://issues.redhat.com/browse/RHOAIENG-7919 ADR: opendatahub-io/architecture-decision-records#45 --------- Signed-off-by: jooho lee <jlee@redhat.com>
* cluster: rename isXManaged to detectX "is" prefix assumes that it returns boolean value while the functions return actual results. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> * cluster: tune managed/selfmanaged user facing name Jira: https://issues.redhat.com/browse/RHOAIENG-8497 The config map name "addon-managed-odh-catalog" is not pretty enough. Also self managed variant is ambiguous, does not say it explicitly. Change the names to: - Managed Red Hat OpenShift AI - Self Managed Red Hat OpenShift AI Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> --------- Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cfe1c15
into
red-hat-data-services:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple of commits from ODH which should include in rhoai 2.11 (main first)
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
Description
JIRA issue:
How Has This Been Tested?
Screenshot or short clip:
Merge criteria: