chore: removes unused client parameter #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
zdtsw
approved these changes
Jun 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2993707
into
opendatahub-io:incubation
8 checks passed
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Jun 26, 2024
7 tasks
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Jun 26, 2024
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit 2993707)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit 2993707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were passing instance of
client.Clientto the functions that don't need it. Most likely copy-paste mistake.This PR cleans it up.
How Has This Been Tested?
Screenshot or short clip
Merge criteria
Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).