Another 2.8 backport changes #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 007b6af)
* RHOAIENG-3425_Validate_Trusted_CA_Bundle * RHOAIENG-3425 - Lint fixes * RHOAIENG-3425 - Lint fixes * RHOAIENG-3425 - Lint and syntax fixes * RHOAIENG-3425 - Lint and syntax fixes * RHOAIENG-3425 - Lint fixes * RHOAIENG-3425 - Validate Trusted CA Bundle * RHOAIENG-3425 - Remove SM Operator Dependency * RHOAIENG-3425 - Fixed unused VAR * RHOAIENG-3425 - Addressed review feedback * RHOAIENG-3425 - Fixed typo * RHOAIENG-3425 - Doc/Title fix (cherry picked from commit 6b93683)
Signed-off-by: Kobi Hakimi <khakimi@redhat.com> (cherry picked from commit 655ac3b)
red-hat-data-services#1343) Signed-off-by: Tarun Kumar <takumar@redhat.com> (cherry picked from commit 01b755e)
There was a problem hiding this comment.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Robot Results
|
jiridanek
approved these changes
Apr 5, 2024
FedeAlonso
approved these changes
Apr 8, 2024
ca8e4a8
into
red-hat-data-services:releases/2.8.0
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bundle contains following changes backported from
mastertoreleases/2.8.0:CI: tested smoke run only with
rhods/job/rhods-smoke/5057/against RHOAI 2.8.1 RC2.I HAVEN'T included following changes yet since these doesn't affect us directly now (but we should probably backport them for the long-term future):
And eventually also this one should be backported too #1349.