Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new runtime image for tgis with snyk fixes #1340

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update new runtime image for tgis with snyk fixes #1340

merged 3 commits into from
Apr 3, 2024

Conversation

tarukumar
Copy link
Contributor

No description provided.

Signed-off-by: Tarun Kumar <takumar@redhat.com>
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
450 0 0 450 100

@tarukumar tarukumar self-assigned this Apr 2, 2024
@tarukumar tarukumar added enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins labels Apr 2, 2024
Signed-off-by: Tarun Kumar <takumar@redhat.com>
@jstourac
Copy link
Member

jstourac commented Apr 2, 2024

@tarukumar whole of this should be backported to the releases/2.8.0 branch too, I suppose?

@tarukumar
Copy link
Contributor Author

@tarukumar whole of this should be backported to the releases/2.8.0 branch too, I suppose?

yes

@jstourac
Copy link
Member

jstourac commented Apr 2, 2024

@tarukumar whole of this should be backported to the releases/2.8.0 branch too, I suppose?

yes

Would it be possible to share what is the best test to execute and test this change against 2.8.z (if you have it in memory) so I don't have to check sources once backporting this? 🙂

@tarukumar
Copy link
Contributor Author

tarukumar commented Apr 2, 2024

i have already run kserve raw tc with this change:

#rhods-smoke/5041/

@tarukumar whole of this should be backported to the releases/2.8.0 branch too, I suppose?

yes

Would it be possible to share what is the best test to execute and test this change against 2.8.z (if you have it in memory) so I don't have to check sources once backporting this? 🙂

I have already run kserveraw tc with this : rhods-smoke/5041/

running this : https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/LLMs/422__model_serving_llm_tgis.robot
and https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/LLMs/422_model_serving_llm_other_runtimes.robot should be enough . however i have run some tcs manully for issue validate but having this would be good.

Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tarukumar tarukumar merged commit e10f8fb into red-hat-data-services:master Apr 3, 2024
10 checks passed
jstourac pushed a commit to jstourac/ods-ci that referenced this pull request Apr 5, 2024
…ces#1340)

Signed-off-by: Tarun Kumar <takumar@redhat.com>
(cherry picked from commit e10f8fb)
jstourac added a commit that referenced this pull request Apr 8, 2024
This bundle contains following changes backported from `master` to
`releases/2.8.0`:

* 007b6af (#1326)
* 6b93683 (#1310)
* 655ac3b (#1329)
* e10f8fb (#1340)
* 01b755e (#1343)

CI: tested smoke run only with `rhods/job/rhods-smoke/5057/` against
RHOAI 2.8.1 RC2.

----

I HAVEN'T included following changes yet since these doesn't affect us
directly now (but we should probably backport them for the long-term
future):

* 389a773 (#1336)
* de721a3 (#1275)
* 24c43cd (#1334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants