Skip hexa chars in EncapsedStringsToSprintfRector (#6719)

rectorphp · Feb 5, 2025 · 78382d2 · 78382d2
1 parent 95a145f
commit 78382d2
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/...odingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/skip-hexa-chars.php.inc b/...odingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/skip-hexa-chars.php.inc
@@ -0,0 +1,5 @@
+<?php
+
+$key = '...';
+
+$value = "first:\x01second\x01{$key}";
diff --git a/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php b/rules/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector.php
@@ -137,7 +137,21 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkip(InterpolatedString $interpolatedString): bool
     {
-        return $interpolatedString->hasAttribute(AttributeKey::DOC_LABEL);
+        if ($interpolatedString->hasAttribute(AttributeKey::DOC_LABEL)) {
+            return true;
+        }
+
+        foreach ($interpolatedString->parts as $part) {
+            if (! $part instanceof InterpolatedStringPart) {
+                continue;
+            }
+
+            if ($this->containsASCIIChar($part->value)) {
+                return true;
+            }
+        }
+
+        return false;
     }
 
     private function collectEncapsedStringPart(InterpolatedStringPart $interpolatedStringPart): void
@@ -250,4 +264,9 @@ private function createString(string $value): String_
             'kind' => $kind,
         ]);
     }
+
+    private function containsASCIIChar(string $content): bool
+    {
+        return (bool) Strings::match($content, '#[\x00-\x08\x0B\x0C\x0E-\x1F]#');
+    }
 }