[DeadCode] Skip union falsy mixed on trait on RecastingRemovalRector (#…

…6718)
rectorphp · Feb 5, 2025 · 95a145f · 95a145f
1 parent a4c489e
commit 95a145f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/...adCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_union_falsy_mixed_on_trait.php.inc b/...adCode/Rector/Cast/RecastingRemovalRector/Fixture/skip_union_falsy_mixed_on_trait.php.inc
@@ -0,0 +1,9 @@
+<?php
+
+trait SkipUnionFalsyMixedOnTrait
+{
+    public function run(bool $param): bool
+    {
+        return (bool) ($this->config['allow_404'] ?? false);
+    }
+}
diff --git a/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php b/rules/DeadCode/Rector/Cast/RecastingRemovalRector.php
@@ -25,6 +25,7 @@
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
 use Rector\NodeAnalyzer\ExprAnalyzer;
 use Rector\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\Rector\AbstractRector;
@@ -142,6 +143,16 @@ private function shouldSkipCall(Expr $expr): bool
 
     private function shouldSkip(Expr $expr): bool
     {
+        $type = $this->getType($expr);
+
+        if ($type instanceof UnionType) {
+            foreach ($type->getTypes() as $unionedType) {
+                if ($unionedType instanceof MixedType) {
+                    return true;
+                }
+            }
+        }
+
         if (! $this->propertyFetchAnalyzer->isPropertyFetch($expr)) {
             return $this->exprAnalyzer->isNonTypedFromParam($expr);
         }