Implement fine gained notification #4191

beeender · 2017-02-16T12:37:11Z

Add RealmObservable and RealmCollectionObservable interfaces.
Enable detailed change information for RealmResults through
OrderedCollectionChange interface.
Fix a bug in the ObserverPairList which could cause the removed
listener gets called if it was removed during previous listener
iteration.

RealmObject should implement RealmObservable.

Zhuinden · 2017-02-16T16:14:34Z

realm/realm-library/src/main/java/io/realm/BaseRealm.java

@@ -141,7 +141,7 @@ public boolean isInTransaction() {
     * @throws IllegalStateException if you try to remove a listener from a non-Looper Thread.
     * @see io.realm.RealmChangeListener
     */
-    public <T extends BaseRealm> void removeChangeListener(RealmChangeListener<T> listener) {
+    protected  <T extends BaseRealm> void removeListener(RealmChangeListener<T> listener) {


Zhuinden · 2017-02-16T16:15:21Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChange.java

+ */
+public class OrderedCollectionChange {
+    public long[] getDeletions() { return null; }
+    public long[] getInsertertions() { return null; }


I'm pretty sure this should be getInsertions() and I eerily remember stating that in the RFC too 👅

I thought i changed this ...

Zhuinden · 2017-02-16T16:16:01Z

realm/realm-library/src/main/java/io/realm/RealmObservable.java

+package io.realm;
+
+public interface RealmObservable<T> {
+    void addChangeListener(RealmChangeListener<T> listener);


should this also have javadoc?

yeah, just make it work, will add javadoc later.

beeender · 2017-02-17T12:41:40Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChange.java

+     *
+     * @return the indices array.
+     */
+    long[] getChanges();


I feel getModifications() will be a better name, since this class named OrderedCollectionChange. Your thoughts? @realm/java

Sounds fine with me

But considering that RecyclerView has final void notifyItemRangeChanged(int positionStart, int itemCount) method, I think the OrderedCollectionChangeSet + getChanges() is what makes most sense

I agree 👍

beeender · 2017-02-17T12:43:35Z

It still needs more documentation and i met some trouble to make the RealmObject implement RealmObservable. Other than those, it is ready for review.

cmelchior · 2017-02-17T13:04:44Z

realm/realm-library/src/main/java/io/realm/RealmObservable.java

+
+package io.realm;
+
+public interface RealmObservable<T> {


An idea for the javadoc.

A class implementing this interface is capable of reporting when the data stored by the class has changed. When that happens all registered {@link RealmChangeListener}'s will be triggered. This class will only report that something changed, not what changed. @see RealmCollectionObservable for information about more fine-grained collection notifications.

cmelchior · 2017-02-17T13:18:35Z

realm/realm-library/src/main/java/io/realm/RealmCollectionObservable.java

+
+package io.realm;
+
+public interface RealmCollectionObservable<T, S extends OrderedRealmCollectionChangeListener>


Idea for Javadoc:

A collection class implementing this interface is capable of reporting fine-grained notifications about how the collection. It will report insertions, deletions and changes, but not _how_ an individual element changed. When a change is detected all registered listeners will be triggered. This is commonly useful when updating UI elements, e.g `RecyclerView.Adapter` can provide nicer animations and work more effectively if it knows exactly which elements changed. @see RealmObservable for information about more coarse-grained notifications. @see <a href="https://realm.io/docs/java/latest/#adapters">Android Adapters<a>

cmelchior · 2017-02-17T13:29:59Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChange.java

+     *
+     * @return the {@link Range} array.
+     */
+    Range[] getChangeRanges();


getModificationRanges? pr above

Let's not forget that RecyclerView.Adapter calls it "changes" too

final void notifyDataSetChanged()

Notify any registered observers that the data set has changed.

final void notifyItemChanged(int position, Object payload)

Notify any registered observers that the item at position has changed with an optional payload object.

final void notifyItemChanged(int position)

Notify any registered observers that the item at position has changed.

final void notifyItemInserted(int position)

Notify any registered observers that the item reflected at position has been newly inserted.

final void notifyItemMoved(int fromPosition, int toPosition)

Notify any registered observers that the item reflected at fromPosition has been moved to toPosition.

final void notifyItemRangeChanged(int positionStart, int itemCount, Object payload)

Notify any registered observers that the itemCount items starting at position positionStart have changed.

final void notifyItemRangeChanged(int positionStart, int itemCount)

Notify any registered observers that the itemCount items starting at position positionStart have changed.

final void notifyItemRangeInserted(int positionStart, int itemCount)

Notify any registered observers that the currently reflected itemCount items starting at positionStart have been newly inserted.

final void notifyItemRangeRemoved(int positionStart, int itemCount)

Notify any registered observers that the itemCount items previously located at positionStart have been removed from the data set.

final void notifyItemRemoved(int position)

Notify any registered observers that the item previously located at position has been removed from the data set.

Yes, I guess that was where I got the original wording from. In this case though our class is also called OrderedCollectionChange

I don't have a strong preference either way. Calling the class OrderedCollectionModifications doesn't seem much better either.

No, it really doesn't. It feels unnecessarily long 😕

cmelchior · 2017-02-17T13:40:33Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChange.java

+ * The change information is available in two formats: a simple array of row indices in the collection for each type of
+ * change, and an array of {@link Range}s.
+ */
+public interface OrderedCollectionChange {


Should this be Change or Changes since this interface wraps multiple changes?

Or use the same term as the Object store ChangeSet?

ChangeSet sounds like a good idea. That way getChanges/getChangeRanges() also makes a lot of sense IMO

beeender · 2017-02-20T09:00:45Z

realm/realm-library/src/main/java/io/realm/OrderedRealmCollectionChangeListener.java

+     * This will be called when the async query finished at the first time or the collection gets changed.
+     *
+     * @param collection the collection this listener is registered to.
+     * @param changes {@code null} if the it is first time async query returns or information about which rows in the


@realm/java the changes will be null if it is the first time async query returns. It is the same behaviour like cocoa. Anyone think it should return an empty OrderedCollectionChange instead? in that case, we need a new method OrderedCollectionChange.isEmpty() which feels redundant.

Even through there is a difference between zero and no elements, I think null is fine.

I have mixed feelings about it. Normally forcing null-checks onto users leads to a lot of boilerplate, but in this case it does seem like the easiest way to express "no change happened", so I guess returning null is fine.

beeender · 2017-02-20T09:01:30Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChange.java

+    /**
+     * The indices of objects in the previous version of the collection which have been removed from this one.
+     *
+     * @return the indices array.


@realm/java This will return null if no deletion in the changeset, feels right?

null might be better than an artificial NOT_FOUND value.

null is a very bad return value since the canonical use case is something like:

long[] deletions = changes.getDeletions(); for (int i = 0; i < deletions.length; i++) { adapter.notifyItemDleted(deletions[i]); }

IMO returning a 0-sized array would be strongly preferred.

I tend to agree with 0 size array will be better. But will it feel inconsistency with #4191 (comment) ?

A little perhaps, but then again, they will be used in two different contexts. So probably acceptable.

If not, having an isEmpty() doesn't seem that bad to me.

- Add RealmObservable and RealmCollectionObservable interfaces. - Enable detailed change information for RealmResults through OrderedCollectionChange interface. - Fix a bug in the ObserverPairList which could cause the removed listener gets called if it was removed during previous listener iteration. Fix #989

cmelchior

Only review first 3/4 parts of this. Will review the rest later. Only minor comments so far though 👍

cmelchior · 2017-02-20T14:22:37Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+        modifyObjects(realm, 12, 3, 4, 9);
+        realm.commitTransaction();
+        // After transaction, '*' means the object has been modified. 12 has been modified as well, but it is created
+        // and modified in the same transaction, should not be counted in the changes range.


Does the same apply if an object is modified-then-deleted?

yes. Added two tests to ensure that.

cmelchior · 2017-02-20T14:29:50Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+        });
+
+        final CountDownLatch bgDeletionLatch = new CountDownLatch(1);
+        new Thread(new Runnable() {


Any reason this is running in a seperate thread?

// beginTransaction() will make the async query return immediately. So we have to create an object in another // thread. Also, the latch has to be counted down after transaction committed so the async query results can // contain the modification in the background transaction.

Added above comments in test.

cmelchior · 2017-02-20T14:31:13Z

realm/realm-library/src/main/cpp/io_realm_internal_Collection.cpp

+                try {
+                    std::rethrow_exception(err);
+                } catch(const std::exception& e) {
+                    realm::jni_util::Log::e("Caught exception in collection change callback %1", e.what());


I assume same reason for not throwing in SyncClients error handler?

See https://realmio.slack.com/archives/cocoa-team/p1487352481001213?thread_ts=1487331061.001211&cid=C033Z2Y8T . I think user cannot do anything with it :(

cmelchior · 2017-02-20T14:34:29Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChangeSet.java

+    /**
+     * The indices of objects in the previous version of the collection which have been removed from this one.
+     *
+     * @return the indices array. A zero-sized array will be returned if no deletion in the change set.


if no objects where deleted.

cmelchior · 2017-02-20T14:34:46Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChangeSet.java

+    /**
+     * The indices in the new version of the collection which were newly inserted.
+     *
+     * @return the indices array. A zero-sized array will be returned if no insertion in the change set.


if no objects were inserted.

cmelchior · 2017-02-20T14:35:21Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChangeSet.java

+     * For {@link RealmResults}, this means that one or more of the properties of the object at that index were
+     * modified (or an object linked to by that object was modified).
+     *
+     * @return the indices array. A zero-sized array will be returned if no modification in the change set.


if no objects were modified.

cmelchior · 2017-02-20T14:36:03Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChangeSet.java

+    /**
+     *
+     */
+    class Range {


I assume we will add Move if needed later? It will be a breaking change in the API at that point, but a very minor one.

Yes. But i think the commit with suppressing listeners will be more important for the real use cases than move.

Why move will be a breaking change? it only add something to the API without changing others.

Because you are adding a method to an interface. If people implemented that interface they will have to add a new method as well. It is minor I know, but in a strictly SemVer sense it is breaking.

cmelchior · 2017-02-20T14:37:52Z

realm/realm-library/src/main/java/io/realm/OrderedRealmCollectionChangeListener.java

+ */
+public interface OrderedRealmCollectionChangeListener<T> {
+    /**
+     * This will be called when the async query finished at the first time or the collection gets changed.


This will be called when the async query is finished the first time or the collection of objects has changed.

cmelchior · 2017-02-20T14:41:15Z

realm/realm-library/src/main/java/io/realm/RealmResults.java

@@ -61,7 +49,8 @@
 * @see RealmQuery#findAll()
 * @see Realm#executeTransaction(Realm.Transaction)
 */
-public class RealmResults<E extends RealmModel> extends OrderedRealmCollectionImpl<E> {
+public class RealmResults<E extends RealmModel> extends OrderedRealmCollectionImpl<E>
+        implements RealmCollectionObservable<RealmResults<E>, OrderedRealmCollectionChangeListener<RealmResults<E>>> {


Shouldn't this just be implements OrderedRealmCollectionChangeListener<RealmResults<E>>> ?

It implements RealmCollectionObservable<T, S extends OrderedRealmCollectionChangeListener>. Or I have some misunderstanding?

Ups, yeah... those generics are messing with my head 👍

cmelchior · 2017-02-20T14:42:39Z

realm/realm-library/src/main/java/io/realm/RealmResults.java

     */
+    @Deprecated


Add this to the changelog

kneth · 2017-02-20T19:28:09Z

realm/realm-library/src/main/cpp/io_realm_internal_CollectionChangeSet.cpp

+    }
+
+    if (ranges_vector.size() > io_realm_internal_CollectionChangeSet_MAX_ARRAY_LENGTH) {
+        ThrowException(env, IllegalState,


If ranges_vector.size() and io_realm_internal_CollectionChangeSet_MAX_ARRAY_LENGTH are included in the error message, user might have a better chance to find the bug.

You are absolutely right, sir! Changed that.

kneth · 2017-02-20T19:30:16Z

realm/realm-library/src/main/cpp/io_realm_internal_CollectionChangeSet.cpp

+    for (auto index : index_set.as_indexes()) {
+        indices_vector.push_back(index);
+    }
+    if (indices_vector.size() > io_realm_internal_CollectionChangeSet_MAX_ARRAY_LENGTH) {


kneth · 2017-02-20T19:31:02Z

realm/realm-library/src/main/cpp/io_realm_internal_CollectionChangeSet.cpp

+    }
+
+    REALM_UNREACHABLE();
+    return nullptr;


Really needed?

nope. will remove.

kneth · 2017-02-20T19:33:11Z

realm/realm-library/src/main/cpp/io_realm_internal_CollectionChangeSet.cpp

+            return index_set_to_jlong_array(env, change_set.insertions);
+        case io_realm_internal_CollectionChangeSet_TYPE_MODIFICATION:
+            return index_set_to_jlong_array(env, change_set.modifications_new);
+        default:


Why not move REALM_UNREACHABLE(); into the default block?

kneth · 2017-02-20T19:33:21Z

realm/realm-library/src/main/cpp/io_realm_internal_CollectionChangeSet.cpp

+        case io_realm_internal_CollectionChangeSet_TYPE_MODIFICATION:
+            return index_set_to_indices_array(env, change_set.modifications_new);
+        default:
+            break;


kneth · 2017-02-20T19:39:50Z

realm/realm-library/src/main/java/io/realm/OrderedCollectionChangeSet.java

+    Range[] getInsertionRanges();
+
+    /**
+     * The ranges of objects in the new version of the collection which were modified.


kneth · 2017-02-20T19:41:24Z

realm/realm-library/src/main/java/io/realm/RealmCollectionObservable.java

+ * collection is changed. It will report insertions, deletions and changes, but not _how_ an individual element changed.
+ * When a change is detected all registered listeners will be triggered.
+ * <p>
+ * This is commonly useful when updating UI elements, e.g {@code RecyclerView.Adapter} can provide nicer animations and


"commonly" -> "often"
"e.g" -> "e.g."

kneth · 2017-02-20T19:44:38Z

realm/realm-library/src/main/java/io/realm/RealmObservable.java

+package io.realm;
+
+/**
+ * A class implementing this interface is capable of reporting when the data stored by the class has changed. When that


"has" -> "have" (I think "data" is plural in this context: https://en.wikipedia.org/wiki/Data_(word))

kneth · 2017-02-20T19:47:08Z

realm/realm-library/src/main/java/io/realm/internal/CollectionChangeSet.java

+/**
+ * Implementation of {@link OrderedCollectionChangeSet}. This class holds a pointer to the Object Store's
+ * CollectionChangeSet and read from it only when needed. Creating an Java object from JNI when the collection
+ * notification arrives is avoided since we also support the collection listeners without a change set parameter,


"arrives is" -> "arrives, is"

kneth · 2017-02-20T19:48:12Z

realm/realm-library/src/main/java/io/realm/internal/ObserverPairList.java

@@ -49,8 +49,8 @@ public ObserverPair(T observer, S listener) {
            this.observerRef = new WeakReference<T>(observer);
        }

-        // The two pairs will be treated as the same only when the observers are the same and the listeners are the same
-        // as well.
+        // The two pairs will be treated as the same only when the observers are the same and the listeners equal to


Remove "to each other"
"equal" -> "are equal"

The listeners should be check by equality.

cmelchior

Apart from a few minor comments

cmelchior · 2017-02-22T10:34:23Z

realm/realm-library/src/main/java/io/realm/OrderedRealmCollectionChangeListener.java

+     * This will be called when the async query is finished the first time or the collection of objects has changed.
+     *
+     * @param collection the collection this listener is registered to.
+     * @param changes {@code null} if the it is first time async query returns or information about which rows in the


I would probably reverse this to make it easier to read:

@param changeSet Object with information about which rows in the collection were added, removed or modified. {@code null} is returned the first time an async query is completed.

cmelchior · 2017-02-22T10:34:53Z

realm/realm-library/src/main/java/io/realm/OrderedRealmCollectionChangeListener.java

+     * @param changes {@code null} if the it is first time async query returns or information about which rows in the
+     * collection were added, removed or modified.
+     */
+    void onChange(T collection, OrderedCollectionChangeSet changes);


changes -> changeSet, since you did that renaming in the adapter example?

cmelchior · 2017-02-22T10:35:31Z

realm/realm-library/src/main/java/io/realm/RealmCollectionObservable.java

+
+/**
+ * A collection class implementing this interface is capable of reporting fine-grained notifications about how the
+ * collection is changed. It will report insertions, deletions and changes, but not _how_ an individual element changed.


_how -> how

cmelchior · 2017-02-22T10:36:56Z

realm/realm-library/src/main/java/io/realm/RealmCollectionObservable.java

+public interface RealmCollectionObservable<T, S extends OrderedRealmCollectionChangeListener>
+        extends RealmObservable<T> {
+    /**
+     * Adds a change listener to this RealmResults.


to this RealmCollection.

cmelchior · 2017-02-22T10:51:00Z

realm/realm-library/src/main/java/io/realm/RealmObservable.java

+ */
+public interface RealmObservable<T> {
+    /**
+     * Adds a change listener to this {@link RealmResults}, {@link Realm}, {@link DynamicRealm} or {@link RealmObject}.


Missing RealmList

cmelchior · 2017-02-22T11:01:11Z

realm/realm-library/src/main/java/io/realm/internal/CollectionChangeSet.java

+    // Convert long array returned by the nativeGetXxxRanges() to Range array.
+    private Range[] longArrayToRangeArray(long[] longArray) {
+        if (longArray == null) {
+            // Returns a size 0 array so we know the JNI gets called.


know JNI gets called

zaki50

👍 with some minor comments

zaki50 · 2017-02-22T12:42:27Z

CHANGELOG.md

@@ -3,7 +3,11 @@
 ### Breaking changes

 * `RealmResults.distinct()` returns a new `RealmResults` object instead of filtering on the original object (#2947).
-* `RealmResults` is auto-updated continuously. Any transaction on the current thread which may have an impact on the order or elements of the `RealmResults` will change the `RealmResults` immediately instead of change it in the next event loop. The standard `RealmResults.iterator()` will continue to work as normal, which means that you can still delete or modify elements without impacting the iterator. The same is not true for simple for-loops. In some cases a simple for-loop will not work (https://realm.io/docs/java/2.3.1/api/io/realm/OrderedRealmCollection.html#loops), and you must use the new createSnapshot() method.
+* `RealmResults` is auto-updated continuously. Any transaction on the current thread which may have an impact on the order or elements of the `RealmResults` will change the `RealmResults` immediately instead of change it in the next event loop. The standard `RealmResults.iterator()` will continue to work as normal, which means that you can still delete or modify elements without impacting the iterator. The same is not true for simple for-loops. In some cases a simple for-loop will not work (https://realm.io/docs/java/latest/api/io/realm/OrderedRealmCollection.html#loops), and you must use the new createSnapshot() method.


I think that we should revert this since linking to specific version is more suitable for this case.

i agree. change to 3.0.0

zaki50 · 2017-02-22T12:49:48Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+    }
+
+    // The args should be [startIndex1, length1, startIndex2, length2, ...]
+    private void checkRanges(OrderedCollectionChangeSet.Range[] ranges, long... indexAndLen) {


Shouldn't indexAndLen be int...?

zaki50 · 2017-02-22T12:57:04Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+    }
+
+    // Creates AllTypes objects with columnLong set to the value elements in indices array.
+    private void createObjects(Realm realm, long... indices) {


indices should be values?

#4191 (comment)

zaki50 · 2017-02-22T12:57:15Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+    }
+
+    // Modifies AllTypes objects which's columnLong is in the indices array.
+    private void modifyObjects(Realm realm, long... indices) {


indices should be values?

#4191 (comment)

zaki50 · 2017-02-22T12:57:20Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+    }
+
+    // Deletes AllTypes objects which's columnLong is in the indices array.
+    private void deleteObjects(Realm realm, long... indices) {


indices should be values?

It is actually indices. RealmList related tests will share the same test, and to RealmList it is indices.

zaki50 · 2017-02-22T13:08:25Z

realm/realm-library/src/androidTest/java/io/realm/OrderedCollectionChangeSetTests.java

+        });
+
+        final CountDownLatch bgDeletionLatch = new CountDownLatch(1);
+        // beginTransaction() will make the async query return immediately. So we have to create an object in another


create -> delete?

zaki50 · 2017-02-22T13:09:09Z

realm/realm-library/src/androidTest/java/io/realm/RealmResultsTests.java

@@ -979,7 +979,7 @@ public void run() {
    @UiThreadTest
    public void addChangeListener_null() {
        try {
-            collection.addChangeListener(null);
+            collection.addChangeListener((RealmChangeListener)null);


should have a space before null.

zaki50 · 2017-02-22T13:09:13Z

realm/realm-library/src/androidTest/java/io/realm/RealmResultsTests.java

@@ -1024,7 +1024,7 @@ public void run() {
    @UiThreadTest
    public void removeChangeListener_null() {
        try {
-            collection.removeChangeListener(null);
+            collection.removeChangeListener((RealmChangeListener)null);


should have a space before null.

zaki50 · 2017-02-22T14:22:00Z

And I think we should add a sample project for fine grained notification and RecyclerView (in another PR).

…ification

beeender · 2017-02-23T03:06:38Z

@zaki50 yes, the example is here realm/realm-android-adapters#83

realm-ci assigned beeender Feb 16, 2017

beeender added the S:In Progress label Feb 16, 2017

Zhuinden reviewed Feb 16, 2017

View reviewed changes

beeender force-pushed the mc/fine-grained-notification branch from bc55c03 to d7564b1 Compare February 17, 2017 12:37

beeender changed the title ~~WIP fine gained notification~~ Implement fine gained notification Feb 17, 2017

beeender added S:Review and removed S:In Progress labels Feb 17, 2017

beeender commented Feb 17, 2017

View reviewed changes

cmelchior reviewed Feb 17, 2017

View reviewed changes

beeender commented Feb 20, 2017

View reviewed changes

beeender force-pushed the mc/fine-grained-notification branch from d7564b1 to 5d9401a Compare February 20, 2017 13:13

beeender changed the base branch from mc/collection-snapshot to master February 20, 2017 13:14

beeender added the T-Feature label Feb 20, 2017

beeender force-pushed the mc/fine-grained-notification branch from 5d9401a to 2e8be7f Compare February 20, 2017 13:35

cmelchior reviewed Feb 20, 2017

View reviewed changes

kneth reviewed Feb 20, 2017

View reviewed changes

beeender added 3 commits February 21, 2017 13:06

Fix tests and ObserverPair equals bug

8827c34

The listeners should be check by equality.

PR fix

1f12533

Fix javadoc format

84d20cb

cmelchior approved these changes Feb 22, 2017

View reviewed changes

beeender added 2 commits February 22, 2017 19:26

Fix javadoc

a9f4f91

Use int instead long for ChangeSet

474e65c

Rename vars

a4ea03e

zaki50 approved these changes Feb 22, 2017

View reviewed changes

beeender added 2 commits February 22, 2017 22:34

Merge remote-tracking branch 'origin/master' into mc/fine-grained-not…

98be33c

…ification

PR fix

ae2837e

beeender merged commit cc82903 into master Feb 23, 2017

beeender removed the S:Review label Feb 23, 2017

beeender mentioned this pull request Feb 23, 2017

Finegrained notifications #989

Closed

emanuelez deleted the mc/fine-grained-notification branch February 27, 2017 13:59

cmelchior mentioned this pull request Feb 28, 2017

Incorporating DiffUtil into RealmRecyclerViewAdapter realm/realm-android-adapters#59

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024


		package io.realm;

		public interface RealmCollectionObservable<T, S extends OrderedRealmCollectionChangeListener>

Implement fine gained notification #4191

Implement fine gained notification #4191

Conversation

beeender commented Feb 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beeender commented Feb 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhuinden Feb 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmelchior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmelchior left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zaki50 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beeender commented Feb 16, 2017 •

edited

Loading

Zhuinden Feb 17, 2017 •

edited

Loading