Fine grained notification for RecyclerViewAdapter #83

beeender · 2017-02-22T07:57:19Z

No description provided.

cmelchior · 2017-02-22T08:03:05Z

adapters/src/main/java/io/realm/RealmBaseAdapter.java

@@ -87,10 +87,12 @@ public void onChange(BaseRealm results) {
    private void addListener(@NonNull OrderedRealmCollection<T> data) {
        if (data instanceof RealmResults) {


check for instance of RealmCollectionObservable instead? and collapse the two if sections?

Ignore this after removing this interface

- Refresh only the needed part in RecyclerViewAdapter acording to the given change set. - Change Timestamp to Counter and show an ordered results in the views. To show a better experience for recycler view. - Add a edit button to randomly delete/add objects in recycler view. - Remove deprecated methods.

cmelchior · 2017-02-27T14:46:25Z

Currently crashes with:

02-27 09:44:35.634  2781  2794 E AndroidRuntime: FATAL EXCEPTION: Instr: android.support.test.runner.AndroidJUnitRunner
02-27 09:44:35.634  2781  2794 E AndroidRuntime: Process: io.realm.android.tests.test, PID: 2781
02-27 09:44:35.634  2781  2794 E AndroidRuntime: java.lang.IncompatibleClassChangeError: io.realm.AndroidNotifier
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at dalvik.system.DexFile.defineClassNative(Native Method)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at dalvik.system.DexFile.defineClass(DexFile.java:226)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at dalvik.system.DexFile.loadClassBinaryName(DexFile.java:219)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at dalvik.system.DexPathList.findClass(DexPathList.java:338)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:54)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at java.lang.Class.classForName(Native Method)
02-27 09:44:35.634  2781  2794 E AndroidRuntime: 	at java.lang.Class.forName(Class.java:324)
02

When running gw clean :tests:connectedCheck. Not entirely sure why.

zaki50 · 2017-02-27T16:37:12Z

@cmelchior I could reproduce this with 3.0.0-SNAPSHOT from jfrog but worked fine with my local build of 3.0.0-SNAPSHOT.

Something wrong in SNAPSHOT build?

cmelchior · 2017-02-27T16:38:16Z

Perhaps. I had to upload the SNAPSHOT from my local machine because CI didn't do it. Can you try running ojoUpload ?

nhachicha · 2017-02-28T06:54:46Z

adapters/src/main/java/io/realm/RealmBaseAdapter.java


    public RealmBaseAdapter(@Nullable OrderedRealmCollection<T> data) {
        if (data != null && !data.isManaged())
            throw new IllegalStateException("Only use this adapter with managed list, " +
                    "for un-managed lists you can just use the BaseAdapter");
        this.adapterData = data;
-        this.listener = new RealmChangeListener<BaseRealm>() {
+        this.listener = new RealmChangeListener<Object>() {


this should be RealmChangeListener<OrderedRealmCollection<T>> since addListener can only accept RealmResults or RealmList

Agree. I think it's OK to use raw type (RealmChangeListener).
RealmRecyclerViewAdapter also is using raw type.

nhachicha · 2017-02-28T06:59:34Z

adapters/src/main/java/io/realm/RealmRecyclerViewAdapter.java

@@ -85,12 +79,7 @@ public RealmRecyclerViewAdapter(@Nullable OrderedRealmCollection<T> data, boolea
        // Right now don't use generics, since we need maintain two different


nhachicha · 2017-02-28T07:00:50Z

adapters/src/main/java/io/realm/RealmRecyclerViewAdapter.java

@@ -85,12 +79,7 @@ public RealmRecyclerViewAdapter(@Nullable OrderedRealmCollection<T> data, boolea
        // Right now don't use generics, since we need maintain two different
        // types of listeners until RealmList is properly supported.
        // See https://github.com/realm/realm-java/issues/989


is the above assumption still valid? realm/realm-java#989 is closed now?

nhachicha · 2017-02-28T07:04:39Z

build.gradle

@@ -22,11 +25,19 @@ buildscript {
    }
 }

+// Don't cache SNAPSHOT (changing) dependencies.


remember to remove when releasing

nhachicha · 2017-02-28T07:06:25Z

example/src/main/java/io/realm/examples/adapters/model/Counter.java

+public class Counter extends RealmObject {
+    public static final String FIELD_COUNT = "count";
+
+    private static AtomicInteger integerCounter = new AtomicInteger(0);


why static? can't we use a member counter with @Ignore ?

I believe this is in order to have a global counter while the app is running so the list will have ever increasing numbers.

nhachicha · 2017-02-28T07:07:49Z

example/src/main/java/io/realm/examples/adapters/model/Counter.java

    }

-    public void setTimeStamp(String timeStamp) {
-        this.timeStamp = timeStamp;
+    public void setAndIncrease() {


I think increment is probably a more reflective name, as we're not setting any value (method doesn't take args)

nhachicha · 2017-02-28T07:10:35Z

...le/src/main/java/io/realm/examples/adapters/ui/recyclerview/RecyclerViewExampleActivity.java

+        realm.executeTransactionAsync(new Realm.Transaction() {
+            @Override
+            public void execute(Realm realm) {
+                Random rand = new Random();


I think Random is a bit expensive to init. better create it as a member I guess.

nhachicha · 2017-02-28T07:12:06Z

...le/src/main/java/io/realm/examples/adapters/ui/recyclerview/RecyclerViewExampleActivity.java

+                RealmResults<Counter> results = realm.where(Counter.class).findAllSorted(Counter.FIELD_COUNT);
+
+                // Duplicate some existing entries.
+                int countToDup = results.size() > 3 ? 3 : results.size();


countToDup max is 3 (just double checking)

Yes, refactored to named variable for clarity

zaki50 · 2017-02-28T05:52:22Z

CHANGELOG.md

+
+* Removed `RealmBaseAdapter(@Nonnull Context context, @Nullable OrderedRealmCollection<T> data)`.
+* Removed `RealmRecyclerViewAdapter(@NonNull Context context, @Nullable OrderedRealmCollection<T> data, boolean autoUpdate)`.
+


I think that removing RealmBaseAdapter#inflater, RealmBaseAdapter#context, RealmRecyclerViewAdapter#inflater and RealmRecyclerViewAdapter#context are also breaking changes.

zaki50 · 2017-02-28T06:05:52Z

CHANGELOG.md

@@ -1,3 +1,14 @@
+## 2.0.0 (YYYY-MM-DD)


I think we should state supporting Realm-Java version at the beginning of each version entry in Changelog

now 3.x?

Sounds like a good idea.

zaki50 · 2017-02-28T06:08:28Z

adapters/src/main/java/io/realm/RealmBaseAdapter.java

-            realmList.realm.handlerController.addChangeListenerAsWeakReference(listener);
+            RealmList<T> list = (RealmList<T>) data;
+            //noinspection unchecked
+            list.addChangeListener((RealmChangeListener)listener);


need a space after cast

zaki50 · 2017-02-28T07:49:47Z

adapters/src/main/java/io/realm/RealmBaseAdapter.java


    public RealmBaseAdapter(@Nullable OrderedRealmCollection<T> data) {
        if (data != null && !data.isManaged())
            throw new IllegalStateException("Only use this adapter with managed list, " +
                    "for un-managed lists you can just use the BaseAdapter");
        this.adapterData = data;
-        this.listener = new RealmChangeListener<BaseRealm>() {
+        this.listener = new RealmChangeListener<Object>() {


Agree. I think it's OK to use raw type (RealmChangeListener).
RealmRecyclerViewAdapter also is using raw type.

zaki50 · 2017-02-28T07:56:48Z

...le/src/main/java/io/realm/examples/adapters/ui/recyclerview/RecyclerViewExampleActivity.java

+                // Duplicate some existing entries.
+                int countToDup = results.size() > 3 ? 3 : results.size();
+                for (int i = 0; i < countToDup; i++) {
+                    int id = results.get(rand.nextInt((results.size()))).getCount();


Why id?

This value is shared among multiple items.
It does not seem id.

cmelchior · 2017-02-28T09:01:18Z

@nhachicha @zaki50 PR updated

realm-ci assigned beeender Feb 22, 2017

beeender added S:In Progress T-Feature labels Feb 22, 2017

cmelchior reviewed Feb 22, 2017

View reviewed changes

beeender mentioned this pull request Feb 23, 2017

Implement fine gained notification realm/realm-java#4191

Merged

1 task

beeender force-pushed the mc/fine-grained-notification branch from 1c09ba0 to 7f8e368 Compare February 24, 2017 07:44

cmelchior added 4 commits February 27, 2017 13:30

More options for controlling the demo app

b3a90d6

Enable using SNAPSHOT releases

45980f5

Cleanup CHANGELOG

4f88f71

Update build scripts

8bb149d

cmelchior added S:Review and removed S:In Progress labels Feb 28, 2017

nhachicha reviewed Feb 28, 2017

View reviewed changes

zaki50 reviewed Feb 28, 2017

View reviewed changes

PR feedback

624f7cb

nhachicha approved these changes Feb 28, 2017

View reviewed changes

zaki50 approved these changes Feb 28, 2017

View reviewed changes

cmelchior merged commit 2f1c060 into master Feb 28, 2017

cmelchior removed the S:Review label Feb 28, 2017

cmelchior deleted the mc/fine-grained-notification branch February 28, 2017 09:32

cmelchior mentioned this pull request Feb 28, 2017

Incorporating DiffUtil into RealmRecyclerViewAdapter #59

Closed

eygraber mentioned this pull request Mar 5, 2017

Support fine grained notifications in realm mikepenz/FastAdapter#358

Closed

Zhuinden mentioned this pull request Mar 9, 2017

Add support for RecyclerView animations #21

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fine grained notification for RecyclerViewAdapter #83

Fine grained notification for RecyclerViewAdapter #83

beeender commented Feb 22, 2017

cmelchior Feb 22, 2017

cmelchior Feb 27, 2017

cmelchior commented Feb 27, 2017

zaki50 commented Feb 27, 2017 •

edited

Loading

cmelchior commented Feb 27, 2017

nhachicha Feb 28, 2017

zaki50 Feb 28, 2017

nhachicha Feb 28, 2017

nhachicha Feb 28, 2017

nhachicha Feb 28, 2017

nhachicha Feb 28, 2017

cmelchior Feb 28, 2017

nhachicha Feb 28, 2017

nhachicha Feb 28, 2017

nhachicha Feb 28, 2017

cmelchior Feb 28, 2017

zaki50 Feb 28, 2017

zaki50 Feb 28, 2017

kneth Feb 28, 2017

zaki50 Feb 28, 2017

zaki50 Feb 28, 2017

zaki50 Feb 28, 2017

cmelchior commented Feb 28, 2017

		@@ -87,10 +87,12 @@ public void onChange(BaseRealm results) {
		private void addListener(@NonNull OrderedRealmCollection<T> data) {
		if (data instanceof RealmResults) {

		@@ -85,12 +79,7 @@ public RealmRecyclerViewAdapter(@Nullable OrderedRealmCollection<T> data, boolea
		// Right now don't use generics, since we need maintain two different


		* Removed `RealmBaseAdapter(@Nonnull Context context, @Nullable OrderedRealmCollection<T> data)`.
		* Removed `RealmRecyclerViewAdapter(@NonNull Context context, @Nullable OrderedRealmCollection<T> data, boolean autoUpdate)`.

Fine grained notification for RecyclerViewAdapter #83

Fine grained notification for RecyclerViewAdapter #83

Conversation

beeender commented Feb 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmelchior commented Feb 27, 2017

zaki50 commented Feb 27, 2017 • edited Loading

cmelchior commented Feb 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmelchior commented Feb 28, 2017

zaki50 commented Feb 27, 2017 •

edited

Loading