Do not make local-toc contents always visible #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some git blaming and to me, it seems like this added with some changes to local tocs on single html and looks like they have since been deleted. So I think this is safe to revert. |
Blendify
approved these changes
Jan 7, 2018
davidfischer
reviewed
Feb 1, 2018
There was a problem hiding this comment.
I ran a test of this and it looks good but I think that @ericholscher or @agjohnson should take a look before this goes live. I'm not sure I fully understand the implications.
|
I think this is fine. It sounds like a local toc was tested, and I have no historical context to add here. +1 |
agjohnson
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445, but the historic reason why this SASS statement was added is not known.
Created this PR (with built CSS) so it is easier to test.
@ericholscher hinted this may come from #375, which was fixed by @agjohnson