Separated some sass variables #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a solid change, but will let @agjohnson or @snide weigh in. |
|
I haven't tested it, but it's perfectly fine as long as it works. Specificity for coloring is harmless. |
|
It still builds as normal with the grunt file and looks exactly the same before and after the change. |
ericholscher
added a commit
that referenced
this pull request
Jul 30, 2015
Separated some sass variables
|
👍 on more configuration options. We need to document how to use all of our general configuration options. I've merged this in since we don't have an existing way of handling this, but I would love if we stole the ideas alabaster has here: https://github.com/bitprophet/alabaster#theme-options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some additional sass variables to _theme_variables.sass to make it easier to change some colours. The previous colours have been kept in all cases to leave the overall theme the same.