Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all theme options #231

Closed
ericholscher opened this issue Jul 30, 2015 · 4 comments
Closed

Document all theme options #231

ericholscher opened this issue Jul 30, 2015 · 4 comments
Labels
Needed: design decision A core team decision is required Needed: documentation Documentation is required Needed: patch A pull request is required

Comments

@ericholscher
Copy link
Member

Refs #226

We need to document how to use all of our general configuration options. I've merged this in since we don't have an existing way of handling this, but I would love if we stole the ideas alabaster has here:

https://github.com/bitprophet/alabaster#theme-options

@ghost
Copy link

ghost commented Jul 30, 2015

I love the idea of alabaster's theme options and being able to set stuff like github_user and github_repo. When using this theme locally to show the Edit on Github link I've added

html_context = {
  "display_github": True, # Add 'Edit on Github' link instead of 'View page source'
  "github_user": "IKavanagh",
  "github_repo": project,
  "github_version": "master",
  "conf_py_path": "/doc/",
  "source_suffix": source_suffix,
}

to my conf.py file which is similar to what alabaster have done but is undocumented and probably a bit of a hack.

Their css options that you can change are different to #226. #226 changes the sass files which are compiled into css files. What alabaster do is add their variables like code_highlight to their css_t file as {{theme_code_highlight}}. Comments on a similar approach have been made in #228.

@ericholscher
Copy link
Member Author

Interesting, I wonder if we can support both. I imagine the sass variables
are nicer for folks doing forks and more designy adoption, but the Sphinx
variables are useful for basic customization.

On Thu, Jul 30, 2015 at 12:29 PM, Ian Kavanagh notifications@github.com
wrote:

I love the idea of alabaster's theme options and being able to set stuff
like github_user and github_repo. When using this theme locally to show
the Edit on Github link I've added

html_context = {
"display_github": True, # Add 'Edit on Github' link instead of 'View page source'
"github_user": "IKavanagh",
"github_repo": project,
"github_version": "master",
"conf_py_path": "/doc/",
"source_suffix": source_suffix,
}

to my conf.py file which is similar to what alabaster have done but is
undocumented and probably a bit of a hack.

Their css options that you can change are different to #226
#226. #226
#226 changes the sass
files which are compiled into css files. What alabaster do is add their
variables like code_highlight to their css_t file as
{{theme_code_highlight}}. Comments on a similar approach have been made
in #228 #228.


Reply to this email directly or view it on GitHub
#231 (comment)
.

Eric Holscher
Maker of the internet residing in Portland, Oregon
http://ericholscher.com

@Blendify
Copy link
Member

Where should we document this? https://github.com/rtfd/readthedocs.org/tree/master/docs create a wiki page in this repo? in the readme?

@Blendify Blendify added Needed: design decision A core team decision is required Needed: documentation Documentation is required Needed: patch A pull request is required labels Mar 10, 2017
@ericholscher
Copy link
Member Author

ericholscher commented Mar 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required Needed: documentation Documentation is required Needed: patch A pull request is required
Projects
None yet
Development

No branches or pull requests

2 participants