Add support for unix:// transport #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this may look good functionally, it unfortunately lacks documentation and tests. I've prepared a very much similar PR, do you feel like updating or should I file mine? 👍 |
|
I added some test, but hhvm fails. I will try to fix it tomorrow. |
|
Ok, i made ugly hack for hhvm because there is a bug in hhvm (see facebook/hhvm#7733). Tomorrow I will add some info in readme about the unix sockets. |
clue
reviewed
Mar 26, 2017
| //if unix socket we must delete socket file | ||
| if ($metaData['stream_type'] == 'unix_socket') { | ||
| //ugly hhvm hack see bug https://github.com/facebook/hhvm/issues/7733 | ||
| unlink(rtrim($socket_path,":")); |
There was a problem hiding this comment.
Shouldn't this workaround only be applied to affected versions?
| fclose($this->master); | ||
|
|
||
| //if unix socket we must delete socket file |
There was a problem hiding this comment.
I agree that this probably makes sense in most cases, but is this really a "must"?
There was a problem hiding this comment.
We need to delete socket file, because the socket file will remain after server close.
clue
added a commit
to clue-labs/socket
that referenced
this pull request
Mar 29, 2017
Simplify test suite by relying on React's secure TLS server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for unix domain socket transport for using unix:// for connections.