stream_socket_get_name function add ":" for unix domain socket.

[s2x]

The stream_socket_get_name function add ":" when using a unix domain socket.

HHVM Version

3.18.1

Standalone code, or other way to reproduce the problem

<?php
$socket = stream_socket_server("unix://test.sock", $errno, $errstr);
if (!$socket) {
  echo "$errstr ($errno)<br />\n";
} else {
  $socket_path = stream_socket_get_name($socket, false);
  echo "$socket_path\n";
  fclose($socket);
  unlink($socket_path);
}

Expected result

test.sock

Actual result

test.sock:

Warning: unlink(test.sock:): No such file or directory in test.php on line 9

[mofarrell]

It looks like https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/stream/ext_stream.cpp#L827 needs a case to handle this.

[s2x]

I have made PR for this issue #7738