Reject listening on hostnames and document valid URIs #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
requested changes
Jan 27, 2017
README.md
Outdated
| ``` | ||
|
|
||
| In order to change the host the socket is listening on, you can provide an IP | ||
| addres through the first parameter provided to the constructor, optionally |
src/Server.php
Outdated
| * provided to the constructor. | ||
| * As above, the `$uri` parameter can consist of only a port, in which case the | ||
| * server will default to listening on the localhost address `127.0.0.1` and thus | ||
| * it will not be reachable from outside of this system. |
There was a problem hiding this comment.
src/Server.php
Outdated
| * ``` | ||
| * | ||
| * In order to change the host the socket is listening on, you can provide an IP | ||
| * addres through the first parameter provided to the constructor, optionally |
README.md
Outdated
| provided to the constructor: | ||
| As above, the `$uri` parameter can consist of only a port, in which case the | ||
| server will default to listening on the localhost address `127.0.0.1` and thus | ||
| it will not be reachable from outside of this system. |
There was a problem hiding this comment.
superfluous it (not sure)? Maybe: and thus will not be reachable...
|
Updated to fix typos |
jsor
approved these changes
Feb 5, 2017
WyriHaximus
approved these changes
Feb 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listening on a hostname such as
example.comorlocalhostis a blocking operation. This simple PR enforces the host to consists of an IP address.Fixes / closes #7
Refs / builds on top of #65