Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Sharing Broken in 1.8.12 #297

Closed
mbabker opened this issue Feb 23, 2018 · 3 comments
Closed

Session Sharing Broken in 1.8.12 #297

mbabker opened this issue Feb 23, 2018 · 3 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Feb 23, 2018

Unless I've missed something obvious, the shared session setup as described in https://github.com/GeniusesOfSymfony/WebSocketBundle/blob/master/Resources/docs/SessionSetup.md does not work on the 1.8.12 RC. For this functionality to work, it seems to rely on being able to set the hostname as the websocket system's host, but reactphp/socket#66 changed the underlying library to enforce an IP address.

@tkuska
Copy link
Contributor

tkuska commented Feb 23, 2018

it works :)
i had the same problem, it forces to use IP in PHP config, but session depends on cookies used by javascript client in twig template.
This example https://github.com/GeniusesOfSymfony/WebSocketBundle/blob/master/Resources/docs/ClientSetup.md#step-2-gos_web_socket_clientjs uses IP address but you should use your domain there to make it work.
var websocket = WS.connect("ws://your.domain:8080"); or just use IP in web browser :)

@mbabker
Copy link
Contributor Author

mbabker commented Feb 23, 2018

Well, that breaks the Twig globals exposed through the shared config option then (because you basically have to use IP for server config and hostname for the client). Either way I can make this work now.

@tkuska
Copy link
Contributor

tkuska commented Feb 23, 2018

true :)

@mbabker mbabker closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants