Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit bind exception #398

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Add explicit bind exception #398

merged 1 commit into from
Jul 24, 2018

Conversation

smaldini
Copy link
Contributor

@smaldini smaldini commented Jul 24, 2018

Remove unused code

Fix for #368

Remove unused code
@smaldini smaldini added the type/enhancement A general enhancement label Jul 24, 2018
@violetagg violetagg added this to the 0.8.0.M1 milestone Jul 24, 2018
@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #398 into master will increase coverage by 0.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #398      +/-   ##
============================================
+ Coverage     64.06%   64.15%   +0.09%     
- Complexity     1201     1204       +3     
============================================
  Files           117      118       +1     
  Lines          5610     5619       +9     
  Branches        732      734       +2     
============================================
+ Hits           3594     3605      +11     
+ Misses         1616     1612       -4     
- Partials        400      402       +2
Impacted Files Coverage Δ Complexity Δ
...tor/netty/http/server/HttpServerConfiguration.java 94.33% <ø> (-0.11%) 16 <0> (ø)
src/main/java/reactor/netty/tcp/TcpServerBind.java 86.51% <100%> (+4.29%) 11 <0> (ø) ⬇️
...reactor/netty/resources/NewConnectionProvider.java 70% <50%> (+4.24%) 7 <0> (ø) ⬇️
.../main/java/reactor/netty/ChannelBindException.java 64.28% <64.28%> (ø) 4 <4> (?)
...eactor/netty/http/server/HttpServerOperations.java 67.5% <0%> (-0.5%) 57% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6074d4...2c6ac5a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants