fix #368 Throw a marker exception with local address information when server bind fails #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server bind fails
simonbasle
reviewed
Jul 24, 2018
| Throwable t = f.cause(); | ||
| if (t != null) { | ||
| if (t instanceof BindException) { | ||
| t = new DisposableServerBindException(t.getMessage() + " " + localAddress, localAddress); |
There was a problem hiding this comment.
Would it make sense to craft a dedicated message for the DSBE that is more explicit and keep the original BindException as a cause?
(here we completely lose the stacktrace, but maybe the BindException has no fillInStackTrace either?)
|
Close in favour of #398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.