Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MonoSend.MAX_SIZE configurable by system property #3276

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Make MonoSend.MAX_SIZE configurable by system property #3276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d821a8
Make MonoSend.MAX_SIZE configurable by system property (#3255)
VadimKirilchuk Jun 4, 2024
274a6a2
Rename max prefetch size property and move to appropriate class (#3255)
VadimKirilchuk Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion reactor-netty-core/src/main/java/reactor/netty/ReactorNetty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011-2023 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2011-2024 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -198,6 +198,11 @@ public final class ReactorNetty {
*/
public static final ZoneId ZONE_ID_SYSTEM = ZoneId.systemDefault();

/**
* Default prefetch size ({@link Subscription#request(long)}) for data stream Publisher, fallback to 128.
*/
public static final String REACTOR_NETTY_SEND_MAX_PREFETCH_SIZE = "reactor.netty.send.maxPrefetchSize";

/**
* Try to call {@link ReferenceCounted#release()} if the specified message implements {@link ReferenceCounted}.
* If the specified message doesn't implement {@link ReferenceCounted} or it is already released,
Expand Down
5 changes: 3 additions & 2 deletions reactor-netty-core/src/main/java/reactor/netty/channel/MonoSend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019-2023 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2019-2024 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -58,7 +58,8 @@ static <O> ToIntFunction<O> defaultSizeOf() {
return (ToIntFunction) SIZE_OF;
}

static final int MAX_SIZE = 128;
static final int MAX_SIZE =
Integer.parseInt(System.getProperty(ReactorNetty.REACTOR_NETTY_SEND_MAX_PREFETCH_SIZE, "128"));

static final int REFILL_SIZE = MAX_SIZE / 2;

Expand Down