-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MonoSend.MAX_SIZE
configurable by system property
#3276
Make MonoSend.MAX_SIZE
configurable by system property
#3276
Conversation
@VadimKirilchuk Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@VadimKirilchuk Thank you for signing the Contributor License Agreement! |
MonoSend.MAX_SIZE
configurable by system property
reactor-netty-core/src/main/java/reactor/netty/channel/MonoSend.java
Outdated
Show resolved
Hide resolved
@violetagg I did the change, some tests are failing locally, but seems to be unrelated. |
I have also checked running that locally with some stub Flux Publisher:
Seems to work as expected. Please let me know if you need anything else from my side. Also, do you want me to create a similar PR for 1.2.x? I am not sure if you are simply doing merges from 1.1.x -> 1.2.x. |
There is no need. We use Thanks for the PR! |
MonoSend.MAX_SIZE is a constant used by MonoSendMany and its SendManyInner class to request initial items from a publisher to send to an output Channel. This PR introduces a way to configure MonoSend.MAX_SIZE by using
reactor.netty.channel.send.prefetch.maxSize
(Upd.reactor.netty.send.maxPrefetchSize
) system property. A custom value for the property may be necessary if requested items from publisher are large and requesting default number of items (128) requires too much memory.Fixes #3255