Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dots in parametrized path segments #31

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

mtritschler
Copy link
Contributor

Fixes part of #30

@pivotal-issuemaster
Copy link

@mtritschler Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@smaldini
Copy link
Contributor

smaldini commented Jan 31, 2017

Hey @mtritschler would you mind signing the cla so we get that in ?

@smaldini smaldini added this to the 0.6.1.RELEASE milestone Jan 31, 2017
@smaldini smaldini added the type/enhancement A general enhancement label Jan 31, 2017
@mtritschler
Copy link
Contributor Author

@smaldini, sure. But I need to get approval from our legal department first... #thuglife
I have already reached out to them, answer still pending.

To speed things up; does this maybe fall into the "obvious fix" bucket?

@pivotal-issuemaster
Copy link

@mtritschler This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@simonbasle
Copy link
Contributor

@mtritschler this is not an obvious fix (as described in the CLA tool's FAQ) unfortunately. But it look like simply putting the words in a PR comment marks the PR as obvious in the mind of the tool... Bad robot, bad 🤖
👩‍⚖️ please continue spamming your legal department about the CLA 👨‍⚖️

@smaldini
Copy link
Contributor

Awesome, you are a true hero @mtritschler 🗡 - we'll look at the other problem about query parameters separately.

@smaldini smaldini merged commit 2a1a37f into reactor:master Feb 13, 2017
@smaldini
Copy link
Contributor

I consider it an obvious fix for now, however its borderline due to the Regex change, we'll know for next time ;D However for further more advanced PR stuff we'll take a look.

@simonbasle
Copy link
Contributor

@mtritschler despite that, if you can get to signing the CLA, that would be great ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants