Path parameter parsing should allow dots in segments and ignore query parameters

[mtritschler]

There seems to be a problem with pattern matching for paths in HTTP requests in reactor-netty 0.6.0.RELEASE. Please consider the four examples below. They outline two different problems that are all related to (at least for me) unexpected behaviour of the pattern matcher. In summary they are

1. Dots in parameterized segments break pattern matching (/{x} won't match /a.b)
2. Query parameters break pattern matching, event without path params (/search won't match /search?q=reactor)

The last example with /test/{order} illustrates nicely the brokenness of the implementation here as soon as query parameters come into play (given a path /test/foo?q=bar, the value for order will be foo?q=bar).

package reactor.ipc.netty.http.server;
import org.junit.Test;
import reactor.ipc.netty.http.server.HttpPredicate.UriPathTemplate;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;

public class UriPathTemplateTest {

    @Test
    public void patternShouldMatchPathWithOnlyLetters() {
        UriPathTemplate uriPathTemplate = new UriPathTemplate("/test/{order}");
        // works as expected
        assertThat(uriPathTemplate.match("/test/1").get("order"), is("1"));
    }

    @Test
    public void patternShouldMatchPathWithDots() {
        UriPathTemplate uriPathTemplate = new UriPathTemplate("/test/{order}");
        // does not match, the dot in the segment parameter breaks matching
        // expected: a map containing {"order": "2.0"}, found: empty map
        assertThat(uriPathTemplate.match("/test/2.0").get("order"), is("2.0"));
    }

    @Test
    public void staticPatternShouldMatchPathWithQueryParams() {
        UriPathTemplate uriPathTemplate = new UriPathTemplate("/test/3");
        // does not match, the query parameter breaks matching
        // expected: true, found: false
        assertThat(uriPathTemplate.matches("/test/3?q=reactor"), is(true));
    }

    @Test
    public void parameterizedPatternShouldMatchPathWithQueryParams() {
        UriPathTemplate uriPathTemplate = new UriPathTemplate("/test/{order}");
        // does not match, the query parameter breaks matching
        // expected: a map containing {"order": "3"}, found: a map containing {"order": "3?q=reactor"}
        assertThat(uriPathTemplate.match("/test/3?q=reactor").get("order"), is("3"));
    }

}

[mtritschler]

Maybe the issue is not caused by the UriPathTemplate but rather by the fact that the server uses the full result of HttpServerRequest#uri() (including query params) for matching the path instead of just the path

HttpServer.create(port).newRouter(routes ->
    routes.get("/echo/{message}", (req, res) -> 
        res.sendString(Mono.just(req.param("message"))));
// GET /echo/hello => 200 OK "hello"
// GET /echo/hello?a=b => 200 OK "hello?a=b"
// GET /echo/hello.world => 404 Not Found

This makes it impossible to use this API for defining routes for endpoints that accept query params or parameterized path segments may contain dots.