Allow providing custom attributes to <Tab> (spread attributes) #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to provide custom attributes to
<Tab>
through attribute spreading on the rendered<li>
component. This allows both overriding of the existing attributes (except className) and to provide new attributes as shown in the tests.This solves my wish to be able to set "data-tip" for tooltips with
react-tooltip
, and resolves PR #92 and issue #44Edit: would also provide a solution for #97
Edit2: Oops, didn't know a PR would automatically update with new commits, moved the commits not related to this PR to a different branch and force reset master, PR should be ok now.