Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow style to be set directly on Tab components. #92

Closed
wants to merge 1 commit into from
Closed

Allow style to be set directly on Tab components. #92

wants to merge 1 commit into from

Conversation

happycollision
Copy link

@happycollision happycollision commented Apr 15, 2016 •
edited
Loading

Tab components are the only things inside Tabs components that aren't really wrappers. They, in my experience, are often the actual element that users will interact with. Rather than

<Tab><span style={style.tab}>My Tab</span></Tab>

It might be nice to

<Tab style={style.tab}>My Tab</Tab>

@MartijnHols MartijnHols mentioned this pull request Apr 19, 2016
Closed
@danez
Copy link
Collaborator

danez commented Jun 13, 2016

This was done in #93

@danez danez closed this Jun 13, 2016
@happycollision happycollision deleted the patch-allow-styles-on-tab-components branch July 24, 2016 00:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@happycollision @danez