Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinking in react - full Hindi translation #61

Closed

Conversation

mayank-gangwal
Copy link

I've created the PR as some of the translations are still in discussion mode. I'd like you to review the remaining of the doc, we may do the necessary changes meanwhile.

Requesting @arshadkazmi42 and @saranshkataria to review the PR.

@netlify
Copy link

netlify bot commented Dec 4, 2019

Deploy preview for hi-reactjs ready!

Built with commit 5ce1d22

https://deploy-preview-61--hi-reactjs.netlify.app

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
Added some comments till line 35

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@mayank-gangwal
Copy link
Author

@arshadkazmi42 what do you suggest? Should I start working on the review comments already? Or wait for you to complete the review of whole file? There'd be multiple commits in prior case.

@arshadkazmi42
Copy link
Member

arshadkazmi42 commented Dec 10, 2019

@mayank-gangwal start working on the comments. we review it in parts. You can read about our review process at #23

@arshadkazmi42 arshadkazmi42 added 1st Review First phase of review and removed awaiting author response labels Jan 24, 2020
@arshadkazmi42
Copy link
Member

Good work with fixes. Added one more minor comment and we will continue with review post that is fixed

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good going. Added review till 61.

Let's get these fixed, then we will continue further with the review

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great going.
Added review till 76

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

Good work. You missed a couple of feedbacks. Let's get those fixed before continuing with further reviews

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Added review for rest of the file.
once these are fixed, this will be good to go from my end

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.
For next steps there will be a second round of review by @saranshkataria
Post that we will get this merged.

Thank you for working on all the fixes

@arshadkazmi42 arshadkazmi42 added 2nd Review Second phrase of review and removed 1st Review First phase of review labels Feb 15, 2020
permalink: docs/thinking-in-react.html
redirect_from:
- 'blog/2013/11/05/thinking-in-react.html'
- 'docs/thinking-in-react-zh-CN.html'
prev: composition-vs-inheritance.html
---

React is, in our opinion, the premier way to build big, fast Web apps with JavaScript. It has scaled very well for us at Facebook and Instagram.
हमारी राय में, जावास्क्रिप्ट द्वारा, बड़ी और तेज़ वेब एप्पस बनाने का React एक मुख्य तरीका है। यह हमारे लिए Facebook और Instagram के लिए काफी अच्छे से बढ़ा है।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

हमारी राय में, जावास्क्रिप्ट द्वारा, बड़ी और तेज़ वेब एप्पस बनाने का React एक मुख्य तरीका है। changes the meaning of the sentence, reword the order of words

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React, हमारी राय में, जावास्क्रिप्ट द्वारा, बड़ी और तेज़ वेब एप्पस बनाने का एक मुख्य तरीका है।
Better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds better


One of the many great parts of React is how it makes you think about apps as you build them. In this document, we'll walk you through the thought process of building a searchable product data table using React.
कई में से एक मुख्य बात React की है कि कैसे यह आपको एप्प बनाते हुए उसके बारे में सोचने पर मजबूर करता है। इस डॉक्यूमेंट में हम React से बने सर्चएब्ल प्रोडक्ट डाटा टेबल को बनाने की विचार प्रक्रिया पर ध्यान देंगे।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reword sentences here as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React की कई में से एक मुख्य बात यह है कि यह कैसे आपको एप्प बनाते हुए उसके बारे में सोचने पर मजबूर करता है। इस डॉक्यूमेंट में हम React के द्वारा बने सर्चएब्ल प्रोडक्ट डाटा टेबल को बनाने की विचार प्रक्रिया पर ध्यान देंगे।
Better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first line could be changed to -> React की कई में से एक मुख्य बात यह है कि यह आपको एप्प बनाते हुए उसके बारे में सोचने पर मजबूर करता है।

rest is good


![Mockup](../images/blog/thinking-in-react-mock.png)

Our JSON API returns some data that looks like this:
हमारी JSON API कुछ ऐसा डाटा वापस भेजेगी:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

भेजेगी could be replaced by a better word

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

लौटाएगी could be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes


![Mockup](../images/blog/thinking-in-react-mock.png)

Our JSON API returns some data that looks like this:
हमारी JSON API कुछ ऐसा डाटा वापस भेजेगी:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

words in code such as sporting goods and names could be translated as well

Copy link
Author

@mayank-gangwal mayank-gangwal Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are JSON structures, translations to it could be more confusing, what do you suggest?

"price" to something called "keemat"
"true" to "sahi" false to "galat"
"name" to "naam"? "iPhone/Nexus" to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the keys won't be translated, only values. Sporting Goods, electronics, Football etc.

@saranshkataria
Copy link
Member

added comments till {#step-1-break-the-ui-into-a-component-hierarchy}

@mayank-gangwal
Copy link
Author

@saranshkataria waiting for your inputs. Please go through my comments on yours.

@mayank-gangwal
Copy link
Author

@saranshkataria @arshadkazmi42 waiting for your response since long... Let me know when we may take this page's translation ahead...

@saranshkataria
Copy link
Member

@mayank-gangwal have responded to the comments. Sorry for the delay. Got busy with some things.

@arshadkazmi42
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants