Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with reactjs.org @ b8b3db7a #34

Merged
merged 9 commits into from
Apr 29, 2019
Merged

Sync with reactjs.org @ b8b3db7a #34

merged 9 commits into from
Apr 29, 2019

Conversation

reactjs-translation-bot
Copy link
Contributor

@reactjs-translation-bot reactjs-translation-bot commented Apr 29, 2019

This PR was automatically generated.

Merge changes from reactjs.org at b8b3db7

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.

dantehemerson and others added 7 commits April 26, 2019 21:43
Add this functionality with gatsby-remark-external-links plugin
* add React Boston 2019 to conference page

* add massachusetts to react-boston listing
* Fix anchor link offset with fixed header

* handle h3 too

* h4 as an anchor

* don't affect UI by any means

* no need for px

* more fixes

* consistency

* more consistency

* pixel perfection

* fix h4 after gatsby-highlight

* final touch
The link should probably either go to directly to the beginning of main concepts (which is what my proposes change does), or to the anchor  -tag of "Step-by-Step Guide" (#step-by-step-guide). There is no other link in the article which refers to another anchor-tag, that's why I chose to directly link to the main-concepts.
Also add Mongolian and Catalan.
@netlify
Copy link

netlify bot commented Apr 29, 2019

Deploy preview for hi-reactjs ready!

Built with commit 0a9e7fd

https://deploy-preview-34--hi-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Apr 29, 2019

Deploy preview for hi-reactjs ready!

Built with commit 8b10606

https://deploy-preview-34--hi-reactjs.netlify.com

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@arshadkazmi42 arshadkazmi42 merged commit 1d7aa69 into master Apr 29, 2019
@arshadkazmi42 arshadkazmi42 deleted the sync-b8b3db7a branch April 29, 2019 16:35
mayank-gangwal added a commit to mayank-gangwal/hi.reactjs.org that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants