Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] - Getting Started #17

Merged
merged 39 commits into from
Mar 5, 2019
Merged

Conversation

niyabits
Copy link
Contributor

@niyabits niyabits commented Feb 24, 2019

Translating the Getting Started page to Hindi.
Related to #1
Review Progress

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for hi-reactjs ready!

Built with commit 1be9365

https://deploy-preview-17--hi-reactjs.netlify.com

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
Added few comments.
Also, we want 1 page done by per user.
So you can make other translation in the same branch.
I will assign this page to you in #1

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@niyabits
Copy link
Contributor Author

It shows 2 commits, I hope I have done it correctly.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress.
Suggested a couple of more changes.
Do have a look at hindi glossary at #2

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@niyabits niyabits changed the title Changed few lines of Getting Started Translation - Getting Started Feb 25, 2019
Line 66 - 68 Translated to Hindi
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress with the changes
Added some more review feedbacks.
Once all these are done, we can move on to next part of the pages for review

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@niyabits niyabits changed the title Translation - Getting Started [Translation] - Getting Started Feb 25, 2019
@saranshkataria
Copy link
Member

also need to resolve merge conflicts!

@niyabits
Copy link
Contributor Author

@saranshkataria how do I resolve merge conflicts properly?

@arshadkazmi42
Copy link
Member

@yashguptaz add a comment once you are done with all the changes

@niyabits
Copy link
Contributor Author

Done enough of translation, now you can review.
I will continue afterwards only 8 paragraphs remain, 12 are done I guess.

@arshadkazmi42
Copy link
Member

@yashguptaz we want to go section wise for translation and reviews.
It will be easy to keep track of review comments.
Let's hold on for some time for next sections translation, let's close on the review of what ever is translated till now.
Once everything is approved you can continue with translation of next paragraphs.
Does that makes sense?


Many React users credit reading [Thinking in React](/docs/thinking-in-react.html) as the moment React finally "clicked" for them. It's probably the oldest React walkthrough but it's still just as relevant.
बहुत सारे React के यूज़र्स [React में सोचे](/docs/thinking-in-react.html) पढ़ने को उनकी React कि समझ बढ़ाने में मदद करने का क्रेडिट देते हैं, वह समझते हैं कि इसको पढ़ने के बाद हि उन्हें React समझ में आई | ये React के सबसे पुराने वॉकथ्रू में से एक है |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

कि -> badi maatra

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

हि -> same

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's still just as relevant got lost in translation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bottom 2 ones here haven't been fixed here @yashguptaz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed those now, can you mark any missed ups unresolved?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

समझते हैं कि इसको पढ़ने के बाद one should not have been changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably the oldest React walkthrough but it's still just as relevant. -> but it's still just as relevant has not been translated at all

@saranshkataria
Copy link
Member

Done till {#recommended-courses}. Almost there! 👍

@niyabits
Copy link
Contributor Author

@saranshkataria Done.

@saranshkataria
Copy link
Member

@yashguptaz you have missed a couple

@niyabits
Copy link
Contributor Author

niyabits commented Mar 2, 2019

Fine now?

@niyabits
Copy link
Contributor Author

niyabits commented Mar 2, 2019

@saranshkataria Changed the missed ones too.

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@saranshkataria
Copy link
Member

Added more comments

@niyabits
Copy link
Contributor Author

niyabits commented Mar 5, 2019

@saranshkataria Made more changes.
Please be quick! 👍 :D

@saranshkataria
Copy link
Member

@yashguptaz you missed some but I fixed those too. Great job translating everything! Thanks! 👍

@saranshkataria saranshkataria merged commit 82e9671 into reactjs:master Mar 5, 2019
@arshadkazmi42
Copy link
Member

Great. got another page done 🎉

@arshadkazmi42 arshadkazmi42 mentioned this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants