-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Translation] - Getting Started #17
Conversation
Deploy preview for hi-reactjs ready! Built with commit 1be9365 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start.
Added few comments.
Also, we want 1 page done by per user.
So you can make other translation in the same branch.
I will assign this page to you in #1
It shows 2 commits, I hope I have done it correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress.
Suggested a couple of more changes.
Do have a look at hindi glossary at #2
Line 25-29
Line 60 wasn't properly translated.
Line 62-64
Line 66 - 68 Translated to Hindi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress with the changes
Added some more review feedbacks.
Once all these are done, we can move on to next part of the pages for review
also need to resolve merge conflicts! |
@saranshkataria how do I resolve merge conflicts properly? |
@yashguptaz add a comment once you are done with all the changes |
Till 82
Till Line: 90
Done enough of translation, now you can review. |
@yashguptaz we want to go section wise for translation and reviews. |
content/docs/getting-started.md
Outdated
|
||
Many React users credit reading [Thinking in React](/docs/thinking-in-react.html) as the moment React finally "clicked" for them. It's probably the oldest React walkthrough but it's still just as relevant. | ||
बहुत सारे React के यूज़र्स [React में सोचे](/docs/thinking-in-react.html) पढ़ने को उनकी React कि समझ बढ़ाने में मदद करने का क्रेडिट देते हैं, वह समझते हैं कि इसको पढ़ने के बाद हि उन्हें React समझ में आई | ये React के सबसे पुराने वॉकथ्रू में से एक है | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
कि -> badi maatra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
हि -> same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it's still just as relevant got lost in translation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bottom 2 ones here haven't been fixed here @yashguptaz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed those now, can you mark any missed ups unresolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
समझते हैं कि इसको पढ़ने के बाद one should not have been changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably the oldest React walkthrough but it's still just as relevant. -> but it's still just as relevant has not been translated at all
Done till {#recommended-courses}. Almost there! 👍 |
Till line 94
@saranshkataria Done. |
@yashguptaz you have missed a couple |
Fine now? |
@saranshkataria Changed the missed ones too. |
Added more comments |
@saranshkataria Made more changes. |
@yashguptaz you missed some but I fixed those too. Great job translating everything! Thanks! 👍 |
Great. got another page done 🎉 |
Translating the Getting Started page to Hindi.
Related to #1
Review Progress