Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation for Hello World #38

Merged
merged 16 commits into from
Feb 25, 2019
Merged

Translation for Hello World #38

merged 16 commits into from
Feb 25, 2019

Conversation

setheal
Copy link
Collaborator

@setheal setheal commented Feb 14, 2019

Bonsoir,
Hop à mon tour :)

@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
@Nab69 Nab69 added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 15, 2019
Nab69
Nab69 reviewed Feb 15, 2019
View reviewed changes
Copy link
Member

@Nab69 Nab69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques retouches rapide, mais en tout cas ça se lit bien.
Passes sur le slack de flood de temps à autre @setheal qu'on puisse se faire des retours rapides 😏

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
forresst
forresst suggested changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@forresst forresst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques remarques supplémentaires, rien de bien méchant. Beau travail

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Show resolved Hide resolved
tdd
tdd requested changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @setheal !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main. C'est globalement du bon boulot, y'a juste quelques remarques importantes.

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé.

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Feb 15, 2019
tdd and others added 5 commits February 15, 2019 06:45
@tdd @setheal
Update content/docs/hello-world.md
cc202a3 
Co-Authored-By: setheal <Maelann.BARCIET@supinfo.com>
@tdd @setheal
Update content/docs/hello-world.md
2d9742b 
Co-Authored-By: setheal <Maelann.BARCIET@supinfo.com>
@tdd @setheal
Update content/docs/hello-world.md
0c68e47 
Co-Authored-By: setheal <Maelann.BARCIET@supinfo.com>
@tdd @setheal
Update content/docs/hello-world.md
df5acdd 
Co-Authored-By: setheal <Maelann.BARCIET@supinfo.com>
@tdd @setheal
Update content/docs/hello-world.md
f1240f8 
Co-Authored-By: setheal <Maelann.BARCIET@supinfo.com>
@tdd
Copy link
Collaborator

tdd commented Feb 15, 2019

Salut @setheal j'ai quelques retours pas encore traités sur ta PR, tu peux rejeter un œil ?

@setheal
Copy link
Collaborator Author

setheal commented Feb 16, 2019

Salut @tdd normalement c'est réglé :)

@setheal setheal requested a review from tdd February 25, 2019 09:51
tdd added 2 commits February 25, 2019 17:42
@tdd
ensure all feedback was *indeed* taken into account
96a399f 
Some was not, probably due to lateral scrolling fail.
@tdd
Final tweaks
f23d868
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for fr-reactjs ready!

Built with commit 96a399f

https://deploy-preview-38--fr-reactjs.netlify.com

@tdd tdd merged commit a74539a into reactjs:master Feb 25, 2019
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for fr-reactjs ready!

Built with commit f23d868

https://deploy-preview-38--fr-reactjs.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nab69 Nab69 Nab69 left review comments

@forresst forresst forresst requested changes

@tdd tdd Awaiting requested review from tdd

Assignees
No one assigned
Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@setheal @tdd @forresst @Nab69