Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeouts in TestEnvironment.Receptacle are reported as NPE #29

Closed
rkuhn opened this issue Apr 17, 2014 · 0 comments · Fixed by #30
Closed

timeouts in TestEnvironment.Receptacle are reported as NPE #29

rkuhn opened this issue Apr 17, 2014 · 0 comments · Fixed by #30

Comments

@rkuhn
Copy link
Member

rkuhn commented Apr 17, 2014

When polling the queue, null signals timeout, while the current code assumes a null inside an Optional.
ktoso added a commit to ktoso/reactive-streams that referenced this issue Apr 17, 2014
@ktoso
+tck reactive-streams#29 null checks fixed - null from ABQueue#poll…
4e27c1f 
… means "timeout"
@ktoso ktoso mentioned this issue Apr 17, 2014
Merged
ktoso added a commit to ktoso/reactive-streams that referenced this issue Apr 17, 2014
@ktoso
+tck reactive-streams#29 null checks fixed - null from ABQueue#poll…
d2507e6 
… means "timeout"
@rkuhn rkuhn closed this as completed in #30 Apr 17, 2014
rkuhn added a commit that referenced this issue Apr 17, 2014
@rkuhn
Merge pull request #30 from ktoso/wip-29-fix-nullchecks
566a700 
+tck #29 null checks fixed - `null` from ABQueue#poll means "timeout"
benjchristensen pushed a commit that referenced this issue Apr 24, 2014
@ktoso @benjchristensen
+tck #29 null checks fixed - null from ABQueue#poll means "timeout"
287ca7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

+tck #29 null checks fixed - null from ABQueue#poll means "timeout" ktoso/reactive-streams
1 participant
@rkuhn