Merge pull request #30 from ktoso/wip-29-fix-nullchecks

+tck #29 null checks fixed - `null` from ABQueue#poll means "timeout"
reactive-streams · Apr 17, 2014 · 566a700 · 566a700
2 parents 86cfc18 + d2507e6
commit 566a700
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java b/tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java
@@ -493,10 +493,10 @@ public void assertUncompleted(String errorMsg) {
       env.flop(errorMsg);
     }
 
-
     public void expectCompletion(long timeoutMillis, String errorMsg) throws InterruptedException {
       if (!isCompleted()) {
         T val = abq.poll(timeoutMillis, TimeUnit.MILLISECONDS);
+
         if (val == null) {
           env.flop(String.format("%s within %d ms", errorMsg, timeoutMillis));
         } else {
@@ -528,25 +528,25 @@ public void complete() {
     public T next(long timeoutMillis, String errorMsg) throws InterruptedException {
       Optional<T> value = abq.poll(timeoutMillis, TimeUnit.MILLISECONDS);
 
-      if (value.isEmpty()) {
-        env.flop("Expected element but got end-of-stream");
-      } else if (value.get() == null) {
+      if (value == null) {
         env.flop(String.format("%s within %d ms", errorMsg, timeoutMillis));
-      } else {
+      } else if (value.isDefined()) {
         return value.get();
+      } else {
+        env.flop("Expected element but got end-of-stream");
       }
 
       return null; // keep compiler happy
     }
 
     public Optional<T> nextOrEndOfStream(long timeoutMillis, String errorMsg) throws InterruptedException {
       Optional<T> value = abq.poll(timeoutMillis, TimeUnit.MILLISECONDS);
-      if (value.isDefined()) {
-        return value;
-      } else {
+
+      if (value == null) {
         env.flop(String.format("%s within %d ms", errorMsg, timeoutMillis));
-        return null; // keep compiler happy
       }
+
+      return value;
     }
 
     public List<T> nextN(int elements, long timeoutMillis, String errorMsg) throws InterruptedException {
@@ -564,13 +564,11 @@ public List<T> nextN(int elements, long timeoutMillis, String errorMsg) throws I
     public void expectCompletion(long timeoutMillis, String errorMsg) throws InterruptedException {
       Optional<T> value = abq.poll(timeoutMillis, TimeUnit.MILLISECONDS);
 
-      if (value.isEmpty()) {
-        // ok
-      } else if (value.get() == null) {
+      if (value == null) {
         env.flop(String.format("%s within %d ms", errorMsg, timeoutMillis));
-      } else {
+      } else if (value.isDefined()) {
         env.flop("Expected end-of-stream but got " + value.get());
-      }
+      } // else, ok
     }
 
     void expectNone(long withinMillis, String errorMsgPrefix) throws InterruptedException {