This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
fix(helpers.js): adds platform check to extractColor #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1d40c7 to
ec3b929
Compare
Esemesek
reviewed
Oct 15, 2019
Esemesek
reviewed
Oct 15, 2019
ec3b929 to
f8c8195
Compare
Esemesek
reviewed
Oct 23, 2019
fc99108 to
d487212
Compare
|
@Esemesek is this ready to be merged now? |
|
+1 for fixing the same issue on my end. Patching but keen to see this go in. |
|
Sorry for the delay, I'll check this PR out tomorrow and release a new version. |
|
Thanks @Esemesek! |
|
LGTMT. Thank you for your contribution <3 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stroke is not applied to Shapes on iOS. Works correctly for Android. After doing some debugging, figured out when we pass an array value for color, the prop is completely ignored by RN. Only valid values are string and number. The same solution doesn't work with Android. In android it is expecting an array. Thus adding a platform check in helper.js
P.S. If I import from ReactNativeArt.js, array value for color works for iOS and Android both.
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)