Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress.Pie renders empty on 4.0.0 #173

Closed
felippepuhle opened this issue Oct 21, 2019 · 13 comments
Closed

Progress.Pie renders empty on 4.0.0 #173

felippepuhle opened this issue Oct 21, 2019 · 13 comments

Comments

@felippepuhle
Copy link

felippepuhle commented Oct 21, 2019

Just updated to 4.0.0 and suddenly my Progress.Pie isn't rendering anything.

Screen Shot 2019-10-21 at 9 45 29 AM

Tried to apply some background-color and apparently the wrapper is rendering, as I got a yellow square:

Screen Shot 2019-10-21 at 9 46 13 AM

This is the expected behavior (v3.6.0)

Screen Shot 2019-10-21 at 9 52 01 AM

Any thoughts?

Thanks!

@oblador
Copy link
Owner

oblador commented Oct 21, 2019

The new version uses the community maintained ART library, did you install and configure it?

@felippepuhle
Copy link
Author

Hey @oblador, thanks for your quick response.

Yes, https://github.com/react-native-community/art is correctly installed and configured (I had to remove this hack 'cause I was getting "Duplicate symbols" error, so I guess it's ok)

Thanks!

@axxag
Copy link

axxag commented Oct 21, 2019

Same issue with the Circle component for me. Haven't found a workaround yet (other than downgrading).

@hubertjaruzal
Copy link

@alexxgent Yes, Progress.Circle isn't working on 4.0.0.

@DrummerSi
Copy link

DrummerSi commented Oct 22, 2019

It seems that " visible={true} " needs adding to the Surface, Circle & Shape components within "Pie.js" for it to work... Unfortunately I'm still unable to get Progress.Circle & Progress.CircleSnail working.

Update: After more investigation.. This seems to be an issue with the community ART library. It seems broken in many ways

@oblador
Copy link
Owner

oblador commented Oct 24, 2019

It seems to be related to this issue in RNC ART: react-native-art/art#30

There's a PR to fix it: react-native-art/art#31

@felippepuhle
Copy link
Author

Thanks for the heads up @oblador

Should we close this?

@oblador
Copy link
Owner

oblador commented Oct 25, 2019

Let’s leave it open for me to track that our minimum version should be updated once fixed and for visibility for new users.

Fix for now would be to yarn add react-native-progress@3

@juliafriberg
Copy link

The fix for this has been merged and released https://github.com/react-native-community/art/releases/tag/v1.0.3.

@oblador
Copy link
Owner

oblador commented Nov 15, 2019

Just released 4.0.2 with a bump of RNC ART.

@oblador oblador closed this as completed Nov 15, 2019
@felippepuhle
Copy link
Author

It's working, thank you guys!

@wKovacs64
Copy link

Hmm, the new version throws the following error for me (fresh Expo project on Android):

Error while updating property 'stroke' in shadow node of type: ARTShape

Value for stroke cannot be cast from String to ReadableArray

I can open a new issue if you'd like, although I'm not sure if it belongs here or in ART.

@oblador
Copy link
Owner

oblador commented Nov 16, 2019

I'd open a new ticket in ART

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants