-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support robot controller axis manufacturer code #1360
Support robot controller axis manufacturer code #1360
Conversation
… different manufacturers in one dayisy chain
@kanbouchou Isn't that what |
nm, i see the comment for |
…t_robotControllerAxisManufacturerCode
I've added a bit more comment. Basically, product code by itself is not guaranteed to be globally unique because different manufacturers can happen to have same product code. That's why we need manufacturer code in addition to product code to handle devices from different manufacturers by a single device driver. |
…t_robotControllerAxisManufacturerCode
thanks~ |
Overview
robotControllerAxisManufacturerCode
to joint class to support servos from different manufacturers in a daisy chain._vmimic
indefinitely growing inPyJointInfo::_Update
Detail
robotControllerAxisProductCode
field in joint class already, and we could encode manufacturer name in there as well, but need to introduce a rule (separator) which I wanted to avoid. Also,AttachedSensorInfo
has_sensorMaker
so using same pattern here as well.