Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support robot controller axis manufacturer code #1360

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

kanbouchou
Copy link
Collaborator

@kanbouchou kanbouchou commented Mar 5, 2024

Overview

  • Introduce robotControllerAxisManufacturerCode to joint class to support servos from different manufacturers in a daisy chain.
  • Fix bug with _vmimic indefinitely growing in PyJointInfo::_Update

Detail

  • We have robotControllerAxisProductCode field in joint class already, and we could encode manufacturer name in there as well, but need to introduce a rule (separator) which I wanted to avoid. Also, AttachedSensorInfo has _sensorMaker so using same pattern here as well.

@kanbouchou kanbouchou requested a review from rdiankov March 5, 2024 07:46
@rdiankov
Copy link
Owner

rdiankov commented Mar 6, 2024

@kanbouchou Isn't that what ElectricMotorActuatorInfo::model_type is for?

@rdiankov
Copy link
Owner

rdiankov commented Mar 6, 2024

@kanbouchou Isn't that what ElectricMotorActuatorInfo::model_type is for?

nm, i see the comment for robotControllerAxisProductCode. In that case, i would add a little more to the comment to robotControllerAxisManufacturerCode to explain why it is different from product code.
Thanks,

@kanbouchou
Copy link
Collaborator Author

@kanbouchou Isn't that what ElectricMotorActuatorInfo::model_type is for?

nm, i see the comment for robotControllerAxisProductCode. In that case, i would add a little more to the comment to robotControllerAxisManufacturerCode to explain why it is different from product code. Thanks,

I've added a bit more comment. Basically, product code by itself is not guaranteed to be globally unique because different manufacturers can happen to have same product code. That's why we need manufacturer code in addition to product code to handle devices from different manufacturers by a single device driver.

@rdiankov rdiankov merged commit ce0ff6a into production Apr 3, 2024
1 check passed
@rdiankov rdiankov deleted the support_robotControllerAxisManufacturerCode branch April 3, 2024 10:14
@rdiankov
Copy link
Owner

rdiankov commented Apr 3, 2024

thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants