Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV up to 1.63 #114

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Bump MSRV up to 1.63 #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b5d0c
Bump MSRV up to 1.63 (same as `itertools`)
yotamofek Feb 17, 2025
7972b74
Upgrade to 2021 edition
yotamofek Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: false
matrix:
rust:
- 1.37.0 # MSRV
- 1.63.0 # MSRV
- stable
- beta
- nightly
Expand All @@ -37,15 +37,6 @@ jobs:
with:
toolchain: ${{ matrix.rust }}

- name: MSRV dependencies
if: matrix.rust == '1.37.0'
run: |
cargo generate-lockfile
cargo update -p serde_json --precise 1.0.99
cargo update -p serde --precise 1.0.156
cargo update -p quote --precise 1.0.30
cargo update -p proc-macro2 --precise 1.0.65

- name: Build (no_std)
run: cargo build --no-default-features

Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "either"
version = "1.13.0"
authors = ["bluss"]
edition = "2018"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also upgrade to 2021, if you're so inclined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
I thought about that but wasn't sure you'd want that since itertools is still on 2018.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'll just upgrade itertools to 2021 next 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully, this decision can be made independently! :)
(I'm not a member of itertools, but I expect they'll be fine with that.)

rust-version = "1.37"
rust-version = "1.63.0"

license = "MIT OR Apache-2.0"
repository = "https://github.com/rayon-rs/either"
Expand Down
Loading