Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV up to 1.63 #114

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Bump MSRV up to 1.63 #114

merged 2 commits into from
Feb 17, 2025

Conversation

yotamofek
Copy link
Contributor

@yotamofek yotamofek commented Feb 17, 2025

Supersedes #112

Cargo.toml Outdated
@@ -3,7 +3,7 @@ name = "either"
version = "1.13.0"
authors = ["bluss"]
edition = "2018"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also upgrade to 2021, if you're so inclined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
I thought about that but wasn't sure you'd want that since itertools is still on 2018.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'll just upgrade itertools to 2021 next 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully, this decision can be made independently! :)
(I'm not a member of itertools, but I expect they'll be fine with that.)

Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cuviper cuviper added this pull request to the merge queue Feb 17, 2025
Merged via the queue into rayon-rs:main with commit a91fefd Feb 17, 2025
10 checks passed
@yotamofek yotamofek deleted the msrv branch February 17, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants