Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video Downloader] Unlock its full ability #16845

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Feb 5, 2025

Description

Resolves #16814

  • Unlock its full ability from all sites
  • Move the warning message to the form description
    • We'd better not to handle warning with the toast. Because the process may have both warnings and errors. Warnings from the yt-dlp are usually not a critical issue. So we can move it to form a description for reference.
  • Only show download failed message on errors
  • Fix live video condition
    • The video.live_status can be undefined for some downloadable links
  • Add a link accessory to the form view to show the supported sites
  • Mention the yt-dlp in readme documentation
  • Mention supported sites in readme
  • Comment Can I download clips from YouTube out since we don't support it yet
  • Update screenshots since the format selector is not ready yet

@vimtor Please let me know if you want to change the extension icon and screenshots.

I also plan to add more yt-dlp features to this extension. We can add them in the future PRs.

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: youtube-downloader Issues related to the youtube-downloader extension OP is contributor The OP of the PR is a contributor of the extension labels Feb 5, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 5, 2025

Thank you for your contribution! 🎉

🔔 @vimtor @pernielsentikaer @darmiel @ridemountainpig @remorses @anwarulislam you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

@pernielsentikaer
Copy link
Collaborator

Nice update @LitoMore

@vimtor do you want to check this?

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a shame that it's not possible to set the preferred format as before?

@LitoMore
Copy link
Contributor Author

Isn't it a shame that it's not possible to set the preferred format as before?

See #17176 (comment). I already have some ideas for more settings and will be closer to the full capabilities of yt-dlp instead of just hardcoding the list of options. We can implement that in another PR.

@anwarulislam
Copy link
Contributor

@LitoMore @pernielsentikaer I believe we should implement format selection now. I've already made some changes locally for that feature. I expect this PR will take a little while to review, and the advanced options will also require some time. In the meantime, we can utilize the previous integration of the format selection and trimming feature for YouTube. What are your thoughts?

@LitoMore
Copy link
Contributor Author

I hope my work can be published in stages. This PR has been open for two weeks, and occasionally, I have to deal with conflicts from other PRs. The new formats, clips, quality selector, and playlist features will be another massive change to this extension. I appreciate your understanding.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR transforms the YouTube Downloader into a more versatile Video Downloader by leveraging yt-dlp's extensive site support and improving the user experience.

  • Added Form.LinkAccessory and Form.Description to provide better guidance about supported sites and video status
  • Improved error handling by separating warnings into form descriptions instead of toasts for better UX
  • Fixed live video status validation to handle undefined cases from non-YouTube sites
  • Removed YouTube-specific URL validation in favor of generic URL validation via isUrlSuperb
  • Added experimental IPv4 forcing preference to help users with network issues

Note: The format selector functionality has been temporarily removed in this update. Consider re-implementing this feature in a future PR to maintain previous functionality.

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR continues to enhance the Video Downloader extension by expanding its capabilities and improving documentation. Here's a summary of the latest changes:

  • Updated README.md to rebrand from "YouTube Downloader" to "Video Downloader" for broader platform support
  • Added link to yt-dlp's supported sites documentation in README for user reference
  • Removed outdated FAQ about YouTube clips since the feature isn't currently supported
  • Improved installation instructions clarity regarding ffmpeg and yt-dlp dependencies

The changes focus on better documentation and user guidance while maintaining the extension's core functionality. The updates align well with the extension's expanded scope beyond just YouTube downloads.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit c1e19b1 into raycast:main Feb 21, 2025
2 checks passed
@LitoMore LitoMore deleted the yt-dlp/rename branch February 21, 2025 09:01
Copy link
Contributor

Published to the Raycast Store:
https://raycast.com/vimtor/youtube-downloader

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: youtube-downloader Issues related to the youtube-downloader extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[YouTube Downloader] Unlock its ability for other sites?
5 participants