Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Remove RLlib CLI files, remove other files not needed anymore. #49488

Merged
merged 10 commits into from
Dec 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 9 additions & 24 deletions .buildkite/rllib.rayci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,15 @@ steps:
- bazel run //ci/ray_ci:test_in_docker -- //rllib/... rllib --only-tags torch_2.x_only_benchmark
depends_on: rllibbuild

- label: ":brain: rllib: memory leak pytorch tests"
tags: rllib
instance_type: medium
commands:
- bazel run //ci/ray_ci:test_in_docker -- //rllib/... rllib
--only-tags memory_leak_tests
--except-tags flaky
--test-arg --framework=torch
depends_on: rllibbuild
# - label: ":brain: rllib: memory leak pytorch tests"
# tags: rllib
# instance_type: medium
# commands:
# - bazel run //ci/ray_ci:test_in_docker -- //rllib/... rllib
# --only-tags memory_leak_tests
# --except-tags flaky
# --test-arg --framework=torch
# depends_on: rllibbuild

- label: ":brain: rllib: doc tests"
tags:
Expand Down Expand Up @@ -266,18 +266,3 @@ steps:
--skip-ray-installation # reuse the same docker image as the previous run
depends_on: rllibbuild
soft_fail: true

- label: ":brain: rllib: flaky tests (memory leak)"
key: rllib_flaky_tests_03
tags:
- rllib
- skip-on-premerge
instance_type: medium
commands:
- bazel run //ci/ray_ci:test_in_docker -- //rllib/... rllib
--run-flaky-tests
--only-tags memory_leak_tests
--except-tags flaky,gpu,multi_gpu
--test-arg --framework=tf2
depends_on: rllibbuild
soft_fail: true
4 changes: 0 additions & 4 deletions doc/source/rllib/package_ref/utils.rst
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,4 @@ Other utilities
:toctree: doc/

utils.tensor_dtype.get_np_dtype
common.CLIArguments
common.FrameworkEnum
common.SupportedFileType
core.rl_module.validate_module_id
train.load_experiments_from_file
38 changes: 0 additions & 38 deletions rllib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -1051,44 +1051,6 @@ py_test(
srcs = ["algorithms/sac/tests/test_sac.py"]
)

# --------------------------------------------------------------------
# Memory leak tests
#
# Tag: memory_leak_tests
# --------------------------------------------------------------------

# @OldAPIStack
py_test(
name = "test_memory_leak_appo_old_api_stack",
tags = ["team:rllib", "memory_leak_tests"],
main = "utils/tests/run_memory_leak_tests.py",
size = "large",
srcs = ["utils/tests/run_memory_leak_tests.py"],
data = ["tuned_examples/appo/memory-leak-test-appo.yaml"],
args = ["--dir=tuned_examples/appo"]
)
# @OldAPIStack
py_test(
name = "test_memory_leak_impala_old_api_stack",
tags = ["team:rllib", "memory_leak_tests"],
main = "utils/tests/run_memory_leak_tests.py",
size = "large",
srcs = ["utils/tests/run_memory_leak_tests.py"],
data = ["tuned_examples/impala/memory-leak-test-impala.yaml"],
args = ["--dir=tuned_examples/impala"]
)
# @OldAPIStack
py_test(
name = "test_memory_leak_ppo_old_api_stack",
tags = ["team:rllib", "memory_leak_tests"],
main = "utils/tests/run_memory_leak_tests.py",
size = "large",
srcs = ["utils/tests/run_memory_leak_tests.py"],
data = ["tuned_examples/ppo/memory-leak-test-ppo.yaml"],
args = ["--dir=tuned_examples/ppo"]
)


# --------------------------------------------------------------------
# Connector(V1) tests
# rllib/connector/
Expand Down
Loading
Loading