Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Remove RLlib CLI files, remove other files not needed anymore. #49488

Merged
merged 10 commits into from
Dec 30, 2024
Merged

[RLlib] Remove RLlib CLI files, remove other files not needed anymore. #49488

merged 10 commits into from
Dec 30, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 29, 2024 •
edited
Loading

  • Remove RLlib CLI files.
  • Remove other files not needed anymore.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
52b9adf 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
e157039 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Dec 29, 2024
simonsays1980
simonsays1980 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this clean-up @sven1977 !! Another one bites the dust :D

@sven1977
fixes
0e129c4 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into remo…
17764f0 
…ve_rllib_cli
@sven1977
wip
12a87bd 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into remo…
37db169 
…ve_rllib_cli
@sven1977
wip
a3cd2e5 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 requested review from maxpumperla and a team as code owners December 30, 2024 17:14
@sven1977 sven1977 enabled auto-merge (squash) December 30, 2024 17:29
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 30, 2024
@sven1977
wip
ec272c2 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge December 30, 2024 18:45
@sven1977 sven1977 enabled auto-merge (squash) December 30, 2024 18:47
@sven1977
wip
edb1221 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge December 30, 2024 18:58
@sven1977 sven1977 enabled auto-merge (squash) December 30, 2024 19:46
@sven1977
wip
518c223 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge December 30, 2024 21:34
@sven1977 sven1977 enabled auto-merge (squash) December 30, 2024 21:34
@sven1977 sven1977 merged commit 8e32c0a into ray-project:master Dec 30, 2024
6 checks passed
@sven1977 sven1977 deleted the remove_rllib_cli branch December 31, 2024 12:46
srinathk10 pushed a commit that referenced this pull request Jan 3, 2025
@sven1977 @srinathk10
[RLlib] Remove RLlib CLI files, remove other files not needed anymore. (
f050704 
#49488)
This was referenced Jan 20, 2025
Merged
Merged
aslonnie pushed a commit that referenced this pull request Jan 21, 2025
@mattip
BUILD: remove deleted entry point for rllib (#49977)
7a372c7 
PR #49488 removed the rllib console script but did not remove the entry point. Users will still have a rllib command line command but it will be broken.

Signed-off-by: Matti Picus <matti.picus@gmail.com>
win5923 pushed a commit to win5923/ray that referenced this pull request Jan 23, 2025
@mattip @win5923
BUILD: remove deleted entry point for rllib (ray-project#49977)
a722632 
PR ray-project#49488 removed the rllib console script but did not remove the entry point. Users will still have a rllib command line command but it will be broken.

Signed-off-by: Matti Picus <matti.picus@gmail.com>
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Jan 23, 2025
@mattip @simonsays1980
BUILD: remove deleted entry point for rllib (ray-project#49977)
1ca2bc8 
PR ray-project#49488 removed the rllib console script but did not remove the entry point. Users will still have a rllib command line command but it will be broken.

Signed-off-by: Matti Picus <matti.picus@gmail.com>
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
@mattip @anson627
BUILD: remove deleted entry point for rllib (ray-project#49977)
f40bb66 
PR ray-project#49488 removed the rllib console script but did not remove the entry point. Users will still have a rllib command line command but it will be broken.

Signed-off-by: Matti Picus <matti.picus@gmail.com>
Signed-off-by: Anson Qian <anson627@gmail.com>
srinathk10 pushed a commit that referenced this pull request Feb 2, 2025
@mattip @srinathk10
BUILD: remove deleted entry point for rllib (#49977)
6378d4c 
PR #49488 removed the rllib console script but did not remove the entry point. Users will still have a rllib command line command but it will be broken.

Signed-off-by: Matti Picus <matti.picus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980