Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps commits of opencensus to support building with bzl 0.25.x #4862

Merged
merged 2 commits into from
May 28, 2019
Merged

Update deps commits of opencensus to support building with bzl 0.25.x #4862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a9925
Update deps to support bzl 2.5.x
jovany-wang May 25, 2019
be6c27d
Fix
jovany-wang May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bazel/ray_deps_setup.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,18 @@ def ray_deps_setup():

http_archive(
name = "io_opencensus_cpp",
strip_prefix = "opencensus-cpp-0.3.0",
urls = ["https://github.com/census-instrumentation/opencensus-cpp/archive/v0.3.0.zip"],
strip_prefix = "opencensus-cpp-3aa11f20dd610cb8d2f7c62e58d1e69196aadf11",
urls = ["https://github.com/census-instrumentation/opencensus-cpp/archive/3aa11f20dd610cb8d2f7c62e58d1e69196aadf11.zip"],
)

# OpenCensus depends on Abseil so we have to explicitly pull it in.
# This is how diamond dependencies are prevented.
git_repository(
name = "com_google_absl",
commit = "88a152ae747c3c42dc9167d46c590929b048d436",
commit = "5b65c4af5107176555b23a638e5947686410ac1f",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is from March 27, right?

abseil/abseil-cpp@5b65c4a

Why not a more recent one? Just curious.

Copy link
Contributor Author

@jovany-wang jovany-wang May 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no special requirement to use this commit. Just it was mentioned in #4810. The most recent one on the master branch of absl should be ok as well.

remote = "https://github.com/abseil/abseil-cpp.git",
)

# OpenCensus depends on jupp0r/prometheus-cpp
http_archive(
name = "com_github_jupp0r_prometheus_cpp",
Expand Down