Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ray installation broke with bazel 0.25.x #4810

Closed
fywu85 opened this issue May 17, 2019 · 2 comments · Fixed by #4862
Closed

ray installation broke with bazel 0.25.x #4810

fywu85 opened this issue May 17, 2019 · 2 comments · Fixed by #4862
Assignees

Comments

@fywu85
Copy link

fywu85 commented May 17, 2019

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 19.04
  • Ray installed from (source or binary): source
  • Ray version: latest
  • Python version: 3.6
  • Exact command to reproduce: pip install -e . --verbose

Describe the problem

pip install would fail with bazel version 0.25.x but bazel 0.24.1 works just fine. This is likely caused by census-instrumentation/opencensus-cpp#307

Source code / logs

@jovany-wang
Copy link
Contributor

Thanks for reporting this, I'll take a look.

@jovany-wang jovany-wang self-assigned this May 17, 2019
@tmorgan4
Copy link

tmorgan4 commented May 23, 2019

Disclaimer: I know nothing about C++, opencensus or abseil but making the following changes to ray/bazel/ray_deps_setup.bzl allowed me to build:

http_archive(
    name = "io_opencensus_cpp",
    #strip_prefix = "opencensus-cpp-v0.3.0",
    strip_prefix = "opencensus-cpp-master",
    #urls = ["https://github.com/census-instrumentation/opencensus-cpp/archive/v0.3.0.zip"],
    urls = ["https://github.com/census-instrumentation/opencensus-cpp/archive/master.zip"],
)

# OpenCensus depends on Abseil so we have to explicitly pull it in.
# This is how diamond dependencies are prevented.
git_repository(
    name = "com_google_absl",
    #commit = "88a152ae747c3c42dc9167d46c590929b048d436",
    commit = "5b65c4af5107176555b23a638e5947686410ac1f",
    remote = "https://github.com/abseil/abseil-cpp.git",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants