Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][autoscaler] Cherry picks change to autoscaler intereface #37407

Merged
merged 3 commits into from
Jul 14, 2023
Merged

[core][autoscaler] Cherry picks change to autoscaler intereface #37407

merged 3 commits into from
Jul 14, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jul 14, 2023 •
edited
Loading

This pr contains pick of

Signed-off-by: rickyyx rickyx@anyscale.com

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
[core][autoscaler] Add pg details in details for gang request ray-pro…
145bbf7 
…ject#37161

This adds the PG-related info in details of a GangResourceRequest for observability. This info shouldn't be used for any scaling decisions of autoscaler, but just circles back from autoscaler to be included in cluster status output.
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx requested review from a team, wuisawesome, DmitriGekhtman and ericl as code owners July 14, 2023 00:21
rickyyx added 2 commits July 14, 2023 07:00
@rickyyx
[core][autoscaler] Add node metadata to node state (ray-project#37168)
e639bfa 
This PR adds the below information to node states reported to autoscaler (and ray status for observability):
- node ip address
- cloud instance type

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx
[core][autoscaler] Include failed request info from autoscaler ray-pr…
fa1fa1e 
…oject#37218

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx changed the title [core][autoscaler] Add pg details in details for gang request #37161 [core][autoscaler] Cherry picks change to autoscaler intereface Jul 14, 2023
@bveeramani bveeramani merged commit d340728 into ray-project:releases/2.6.0 Jul 14, 2023
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome wuisawesome is a code owner

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman DmitriGekhtman is a code owner

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@AmeerHajAli AmeerHajAli Awaiting requested review from AmeerHajAli AmeerHajAli is a code owner

@robertnishihara robertnishihara Awaiting requested review from robertnishihara robertnishihara is a code owner

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

Assignees

@zhe-thoughts zhe-thoughts

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickyyx @zhe-thoughts @bveeramani