Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][autoscaler] Add pg details in details for gang request #37161

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jul 6, 2023

Why are these changes needed?

This adds the PG-related info in details of a GangResourceRequest for observability. This info shouldn't be used for any scaling decisions of autoscaler, but just circles back from autoscaler to be included in cluster status output.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx merged commit a7852a4 into ray-project:master Jul 8, 2023
rickyyx added a commit to rickyyx/ray that referenced this pull request Jul 14, 2023
…ject#37161

This adds the PG-related info in details of a GangResourceRequest for observability. This info shouldn't be used for any scaling decisions of autoscaler, but just circles back from autoscaler to be included in cluster status output.
Signed-off-by: rickyyx <rickyx@anyscale.com>
bveeramani pushed a commit that referenced this pull request Jul 14, 2023
* [core][autoscaler] Add pg details in details for gang request #37161

This adds the PG-related info in details of a GangResourceRequest for observability. This info shouldn't be used for any scaling decisions of autoscaler, but just circles back from autoscaler to be included in cluster status output.
Signed-off-by: rickyyx <rickyx@anyscale.com>

* [core][autoscaler] Add node metadata to node state (#37168)

This PR adds the below information to node states reported to autoscaler (and ray status for observability):
- node ip address
- cloud instance type

Signed-off-by: rickyyx <rickyx@anyscale.com>

* [core][autoscaler] Include failed request info from autoscaler #37218

Signed-off-by: rickyyx <rickyx@anyscale.com>

---------

Signed-off-by: rickyyx <rickyx@anyscale.com>
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 28, 2023
…ject#37161

This adds the PG-related info in details of a GangResourceRequest for observability. This info shouldn't be used for any scaling decisions of autoscaler, but just circles back from autoscaler to be included in cluster status output.
Signed-off-by: rickyyx <rickyx@anyscale.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…ject#37161

This adds the PG-related info in details of a GangResourceRequest for observability. This info shouldn't be used for any scaling decisions of autoscaler, but just circles back from autoscaler to be included in cluster status output.
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants