Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix docker image build job names from matrix #36696

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[ci] Fix docker image build job names from matrix #36696

merged 1 commit into from
Jun 22, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

#36409 updated the job names but missed the cpu/cu115/cu116 image build job names, which now all show up as "py37". This PR fixes these names.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

[ci] Fix docker image build job names from matrix
6d28102 
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke requested a review from aslonnie June 22, 2023 06:29
aslonnie
aslonnie approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I think this is also fixed in one of @can-anyscale 's PR's (one of the the py11 one)

@krfricke krfricke merged commit 2734f8e into ray-project:master Jun 22, 2023
@krfricke krfricke deleted the ci/image-matrix branch June 22, 2023 10:08
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@krfricke @arvind-chandra
[ci] Fix docker image build job names from matrix (ray-project#36696)
c56fc42 
ray-project#36409 updated the job names but missed the cpu/cu115/cu116 image build job names, which now all show up as "py37". This PR fixes these names.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

Assignees

@aslonnie aslonnie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krfricke @aslonnie