Use matrix to build docker images on buildkite #36409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
manual branch run that shows that matrix works: https://buildkite.com/ray-project/oss-ci-build-branch/builds/4472#0188b872-125a-4f81-8834-938f09891b16 auto PR run does not show the matrix because it is (incorrectly) skipped. |
can-anyscale
approved these changes
Jun 14, 2023
…ocker Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
|
@aslonnie can you resolve conflicts on this one? |
…ocker Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
done. |
matthewdeng
approved these changes
Jun 15, 2023
| @@ -56,81 +56,32 @@ | |||
| # - if [ "$BUILDKITE_BRANCH" == "master" ]; then python .buildkite/copy_files.py --destination wheels --path ./.whl; fi | |||
|
|
|||
|
|
|||
| - label: ":mechanical_arm: :docker: Build Images: py37 [aarch64] (1/2)" | |||
| - label: ":mechanical_arm: :docker: Build Images: {{matrix}} [aarch64] - cpu/cu115/cu116" | |||
There was a problem hiding this comment.
Should we convert the versions to matrices as well?
There was a problem hiding this comment.
what do you mean ? you mean cpu/cuda versions?
I think they are structured this way because the wheel building part is shared. it is shard-ed into 2 build steps only for slightly faster build time.
8 tasks
krfricke
added a commit
that referenced
this pull request
Jun 22, 2023
#36409 updated the job names but missed the cpu/cu115/cu116 image build job names, which now all show up as "py37". This PR fixes these names. Signed-off-by: Kai Fricke <kai@anyscale.com>
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
ray-project#36409 updated the job names but missed the cpu/cu115/cu116 image build job names, which now all show up as "py37". This PR fixes these names. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid copy and pasting the same code on pipeline definitions.