Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] deprecated jail field in release test definition #36614

Merged
merged 1 commit into from
Jun 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions release/ray_release/buildkite/filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ def filter_tests(
if attr_mismatch:
continue
if not run_jailed_tests:
if test.get("jailed", False):
continue
clone_test = copy.deepcopy(test)
clone_test.update_from_s3()
if clone_test.is_jailed_with_open_issue(TestStateMachine.get_ray_repo()):
Expand Down
9 changes: 6 additions & 3 deletions release/ray_release/buildkite/step.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from ray_release.buildkite.concurrency import get_concurrency_group
from ray_release.test import (
Test,
TestState,
DEFAULT_PYTHON_VERSION,
)
from ray_release.config import (
Expand Down Expand Up @@ -123,11 +124,13 @@ def get_step(
if test.get("run", {}).get("type") == "client":
step["agents"]["queue"] = str(RELEASE_QUEUE_CLIENT)

# If a test is jailed or not stable, allow to soft fail
# If a test is not stable, allow to soft fail
stable = test.get("stable", True)
jailed = test.get("jailed", False)
clone_test = copy.deepcopy(test) # avoid modifying the original test
clone_test.update_from_s3()
jailed = clone_test.get_state() == TestState.JAILED
full_label = ""
if jailed or not stable:
if not stable:
step["soft_fail"] = True
if not stable:
full_label += "[unstable]"
Expand Down
3 changes: 0 additions & 3 deletions release/ray_release/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
"stable": {
"type": "boolean"
},
"jailed": {
"type": "boolean"
},
"python": {
"type": "string",
"enum": [
Expand Down
8 changes: 4 additions & 4 deletions release/ray_release/tests/test_buildkite.py
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ def testGroupTests(self):
self.assertEqual(len(grouped["y"]), 1)

def testGetStep(self):
test = Test(
test = MockTest(
{
"name": "test",
"frequency": "nightly",
Expand Down Expand Up @@ -691,7 +691,7 @@ def testConcurrencyGroupSmokeTest(self):
with open(cluster_config_smoke_path, "w") as fp:
yaml.safe_dump(cluster_config_smoke, fp)

test = Test(
test = MockTest(
{
"name": "test_1",
"cluster": {"cluster_compute": cluster_config_full_path},
Expand All @@ -707,14 +707,14 @@ def testConcurrencyGroupSmokeTest(self):
self.assertEquals(step["concurrency_group"], "small")

def testStepQueueClient(self):
test_regular = Test(
test_regular = MockTest(
{
"name": "test",
"frequency": "nightly",
"run": {"script": "test_script.py"},
}
)
test_client = Test(
test_client = MockTest(
{
"name": "test",
"frequency": "nightly",
Expand Down
5 changes: 0 additions & 5 deletions release/release_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,6 @@
working_dir: air_tests/air_benchmarks/mlperf-train

stable: false
jailed: true

frequency: nightly
python: "3.8"
Expand Down Expand Up @@ -725,7 +724,6 @@
working_dir: air_tests/air_benchmarks/mlperf-train

stable: false
jailed: true

frequency: nightly
python: "3.8"
Expand Down Expand Up @@ -758,7 +756,6 @@
working_dir: air_tests/air_benchmarks/mlperf-train

stable: false
jailed: true

frequency: nightly
team: data
Expand Down Expand Up @@ -4811,7 +4808,6 @@
working_dir: nightly_tests

stable: false
jailed: true

python: "3.8"
frequency: nightly
Expand Down Expand Up @@ -5064,7 +5060,6 @@
working_dir: air_tests

stable: false
jailed: true

frequency: nightly
team: core
Expand Down