-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] deprecated jail field in release test definition #36614
Conversation
Check that https://buildkite.com/ray-project/release-tests-pr/builds/42882 the jailed test runs correctly and the step name is denoted with [jailed] |
Signed-off-by: can <can@anyscale.com>
b87b4ca
to
d0be9b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can one easily tell what is the current state of a test now?
@aslonnie through github issue i guess go/release-test |
@rickyyx fyi, this removed the jailed test feature from release test definition, and rely sole on the test state machine to jail test. Should not change the behavior of your existing jail test significantly. |
So unstable tests will still be running right? ray/release/release_tests.yaml Lines 4757 to 4758 in b9ef5da
|
@rickyyx that's right, they will still be running |
Signed-off-by: can <can@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
Currently the test can be jailed via two ways, either through this 'jailed' field in test definition, or by test state machine. Deprecated this jailed field and let the state machine does it job. This refuses confusion around how to unjail and jail a test.
Also improve the logic of soft fail and append the [jailed] to the buildkite step name. We should not soft fail when the test is jailed.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.