Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disk metric showing double the actual value #32993

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix disk metric showing double the actual value #32993

merged 1 commit into from
Mar 3, 2023

Conversation

alanwguo
Copy link
Contributor

@alanwguo alanwguo commented Mar 3, 2023

Cherry-pick of #32674
Signed-off-by: Alan Guo aguo@anyscale.com

the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them.

In the UI, we show the disk stats for / so I'll do the same for the metric as well.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@alanwguo
Fix disk metric showing double the actual value (ray-project#32674)
0a75162 
Signed-off-by: Alan Guo <aguo@anyscale.com>

the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them.

In the UI, we show the disk stats for / so I'll do the same for the metric as well.
zcin
zcin approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@zcin zcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can ignore the 403s in linkcheck, and the docs.ray.io 404 will be fixed separately.

zhe-thoughts
zhe-thoughts approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for cherry picking into 2.3.1 . This is low risk fix

@zcin zcin merged commit 4032d02 into ray-project:releases/2.3.1 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@zcin zcin zcin approved these changes

Assignees

@zhe-thoughts zhe-thoughts

@zcin zcin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanwguo @zhe-thoughts @zcin