Fix disk metric showing double the actual value #32674
Merged
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Guo <aguo@anyscale.com>
rkooo567
approved these changes
Feb 20, 2023
|
Before merging, do we have tests to verify this works as expected? Also, maybe we should handle the case where "/" doesn't exist (not sure if it is guaranteed to exist)? (also need a test). I also feel like "/" may break windows |
rkooo567
approved these changes
Feb 23, 2023
alanwguo
added a commit
to alanwguo/ray
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Alan Guo <aguo@anyscale.com> the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them. In the UI, we show the disk stats for / so I'll do the same for the metric as well.
7 tasks
zcin
pushed a commit
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Alan Guo <aguo@anyscale.com> the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them. In the UI, we show the disk stats for / so I'll do the same for the metric as well.
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Alan Guo <aguo@anyscale.com> the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them. In the UI, we show the disk stats for / so I'll do the same for the metric as well. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Alan Guo <aguo@anyscale.com> the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them. In the UI, we show the disk stats for / so I'll do the same for the metric as well.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Signed-off-by: Alan Guo <aguo@anyscale.com> the disks stats returns stats about two paths / and /tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them. In the UI, we show the disk stats for / so I'll do the same for the metric as well. Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
the disks stats returns stats about two paths
/and/tmp/ray. Since both those paths are on the same partition, disk_usage will return the same value. We do not need to combine them.In the UI, we show the disk stats for
/so I'll do the same for the metric as well.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.