Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] [Docs] Update "Training a Torch classifier" #28002

Merged
merged 20 commits into from
Sep 7, 2022
Merged

[AIR] [Docs] Update "Training a Torch classifier" #28002

merged 20 commits into from
Sep 7, 2022

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Aug 18, 2022 •
edited
Loading

Signed-off-by: Balaji Veeramani balaji@anyscale.com

Why are these changes needed?

  1. The example wasn't using TorchCheckpoint
  2. The example was using iter_torch_batches incorrectly
  3. The example overcomplicated serving

Depends on:

Related issue number

Closes #28159

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani requested a review from a team as a code owner August 18, 2022 21:36
@bveeramani bveeramani marked this pull request as draft August 18, 2022 21:36
@bveeramani bveeramani marked this pull request as ready for review August 18, 2022 23:10
@bveeramani bveeramani self-assigned this Aug 30, 2022
amogkam
amogkam reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm, thanks! But let's clean up some of the output in the notebook.

doc/source/ray-air/examples/torch_image_example.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/torch_image_example.ipynb Outdated Show resolved Hide resolved
doc/source/ray-air/examples/torch_image_example.ipynb Outdated Show resolved Hide resolved
@bveeramani bveeramani added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Sep 6, 2022
richardliaw
richardliaw approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@amogkam amogkam merged commit f77ac11 into ray-project:master Sep 7, 2022
@peytondmurray peytondmurray mentioned this pull request Sep 7, 2022
Closed
69 tasks
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
@bveeramani @ilee300a
[AIR] [Docs] Update "Training a Torch classifier" (ray-project#28002)
47466e4 
Signed-off-by: Balaji Veeramani balaji@anyscale.com

1. The example wasn't using TorchCheckpoint
2. The example was using iter_torch_batches incorrectly
3. The example overcomplicated serving

Signed-off-by: ilee300a <ilee300@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@amogkam amogkam amogkam approved these changes

Assignees

@matthewdeng matthewdeng

@amogkam amogkam

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AIR] Update "Training a Torch classifier" example
4 participants
@bveeramani @richardliaw @amogkam @matthewdeng